8000 Homogenise `git` and `docker` interface by csegarragonz · Pull Request #679 · faasm/faasm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Homogenise git and docker interface #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Oct 4, 2022
Merged

Homogenise git and docker interface #679

merged 17 commits into from
Oct 4, 2022

Conversation

csegarragonz
Copy link
Collaborator
@csegarragonz csegarragonz commented Sep 30, 2022 •
edited
Loading

This is the third of a three-part PR that implements the following changes in faasm, faabric, and cpp:

  1. Re-factor (if exists) inv release.* to inv git.*.
  2. Add task to bump code version (if it does not exist) inv git.bump
  3. Re-factor (if exists) inv container.* to inv docker.*
  4. Make a common signature for inv docker.build. Stick to inv docker.build -c <ctr_name> [-c <ctr_name_2>] [--nocache] [--push]
  5. Extend the use of venv-bm from faasm to all other repos (a bit unrelated but worth the effort).
  6. In the process of doing 5, try (whenever reasonable) to reduce the number of layers (i.e. RUN commands) in our docker build files. This is recommended in docker's best practices. As always with style guidelines that we can't enforce, it's a bit of a best-effort thing.
  7. Make THIS_DIR resolution zsh-proof (see Make scripts zsh proof #666).

Closes #666
For more background, see faasm/faabric#272.

@csegarragonz csegarragonz mentioned this pull request Sep 30, 2022
Closed
@csegarragonz csegarragonz self-assigned this Sep 30, 2022
@csegarragonz csegarragonz marked this pull request as ready for review September 30, 2022 13:30
@csegarragonz csegarragonz force-pushed the git-docker branch 10 times, most recently from 21cdbe1 to b07abaa Compare October 4, 2022 09:37
@csegarragonz csegarragonz merged commit e6adc71 into main Oct 4, 2022
@csegarragonz csegarragonz deleted the git-docker branch October 4, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shillaker Shillaker Shillaker approved these changes

Assignees

@csegarragonz csegarragonz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make scripts zsh proof
2 participants
@csegarragonz @Shillaker
0