Homogenise git and docker interface
#272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and bump code version
…file style guidelines
… from docker build. in addition, make the distinction between bare metal venvs and container ones. also fix the issue with zsh paths
…d enforce a reduced number of RUN layers
…tall llvm 10 from focal's ones
This was referenced Sep 30, 2022
Shillaker
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toying with the build files in
faasm,faabric, andcpp, I have noticed that there is a naming inconsistency in the tasks we use to manage git/code versions and the tasks to build docker images. These tasks do the same thing in all the repos, and we use them a lot. Ideally we'd have a CLI tool versioned in a different repo, but thats matter for another discussion.In short, tasks to manage
gitare sometimes calledinv release.*and other timesinv git.*. Tasks to managedockerare sometimes calledinv docker.*and other timesinv container.*. In my opinion,inv gitandinv dockerare the most intuitive.This is the first of a three-part PR that implements the following changes in
faasm,faabric, andcpp:inv release.*toinv git.*.inv git.bumpinv container.*toinv docker.*inv docker.build. Stick toinv docker.build -c <ctr_name> [-c <ctr_name_2>] [--nocache] [--push]venv-bmfromfaasmto all other repos (a bit unrelated but worth the effort).RUNcommands) in our docker build files. This is recommended in docker's best practices. As always with style guidelines that we can't enforce, it's a bit of a best-effort thing.THIS_DIRresolutionzsh-proof (see Make scripts zsh proof faasm#666).I am aware that 5 and 6 are a bit out of the scope, but they are small re-factors that should come with some performance/space benefits. That being said, I'd be happy to put them in different PRs.