Fix bad pipe operator in upgrade #848
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D57218457 |
658004e to
d897767
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57218457 |
Summary: Internal tests will never catch the use of Python features (like the pipe operator on types without `__future__.annotations`) that are incompatible with older versions of Python that we still need to support. As a result it's very important that we cover this in gituhub tests; even though we frequently break CI, this at least makes it easy to prep for an open-source release: first check CI for test failures on any supported Python version and fix issues, only then start a release. Unfortunately the script wasn't running upgrade tests, and as a result didn't catch an invalid use of the pipe operator in unguarded type annotations. Differential Revision: D57218140
Summary: This is blocking an open source release. Note: there's a test failure still in OSS in one of these tests. We do need to fix that, but unlike using illegal-for-python-3.9 syntax it doesn't make Pyre unreleasable. Reviewed By: connernilsen Differential Revision: D57218457
d897767 to
d801009
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57218457 |
|
This pull request has been merged in 267a8ce. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestion
2D97
s cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is blocking an open source release.
Note: there's a test failure still in OSS in one of these tests.
We do need to fix that, but unlike using illegal-for-python-3.9
syntax it doesn't make Pyre unreleasable.
Differential Revision: D57218457