Add upgrade tests to test script #847
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D57218140 |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 10, 2024
Summary: Internal tests will never catch the use of Python features (like the pipe operator on types without `__future__.annotations`) that are incompatible with older versions of Python that we still need to support. As a result it's very important that we cover this in gituhub tests; even though we frequently break CI, this at least makes it easy to prep for an open-source release: first check CI for test failures on any supported Python version and fix issues, only then start a release. Unfortunately the script wasn't running upgrade tests, and as a result didn't catch an invalid use of the pipe operator in unguarded type annotations. Differential Revision: D57218140
facebook-github-bot
pushed a commit
that referenced
this pull request
May 10, 2024
Summary: Internal tests will never catch the use of Python features (like the pipe operator on types without `__future__.annotations`) that are incompatible with older versions of Python that we still need to support. As a result it's very important that we cover this in gituhub tests; even though we frequently break CI, this at least makes it easy to prep for an open-source release: first check CI for test failures on any supported Python version and fix issues, only then start a release. Unfortunately the script wasn't running upgrade tests, and as a result didn't catch an invalid use of the pipe operator in unguarded type annotations. Differential Revision: D57218140
stroxler
added a commit
that referenced
this pull request
May 10, 2024
Summary: Internal tests will never catch the use of Python features (like the pipe operator on types without `__future__.annotations`) that are incompatible with older versions of Python that we still need to support. As a result it's very important that we cover this in gituhub tests; even though we frequently break CI, this at least makes it easy to prep for an open-source release: first check CI for test failures on any supported Python version and fix issues, only then start a release. Unfortunately the script wasn't running upgrade tests, and as a result didn't catch an invalid use of the pipe operator in unguarded type annotations. Differential Revision: D57218140
90d952b to
27174d1
Compare
stroxler
added a commit
that referenced
this pull request
May 10, 2024
Summary: Internal tests will never catch the use of Python features (like the pipe operator on types without `__future__.annotations`) that are incompatible with older versions of Python that we still need to support. As a result it's very important that we cover this in gituhub tests; even though we frequently break CI, this at least makes it easy to prep for an open-source release: first check CI for test failures on any supported Python version and fix issues, only then start a release. Unfortunately the script wasn't running upgrade tests, and as a result didn't catch an invalid use of the pipe operator in unguarded type annotations. Differential Revision: D57218140
|
This pull request was exported from Phabricator. Differential Revision: D57218140 |
Summary: Internal tests will never catch the use of Python features (like the pipe operator on types without `__future__.annotations`) that are incompatible with older versions of Python that we still need to support. As a result it's very important that we cover this in gituhub tests; even though we frequently break CI, this at least makes it easy to prep for an open-source release: first check CI for test failures on any supported Python version and fix issues, only then start a release. Unfortunately the script wasn't running upgrade tests, and as a result didn't catch an invalid use of the pipe operator in unguarded type annotations. Reviewed By: connernilsen Differential Revision: D57218140
27174d1 to
6f85dac
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57218140 |
|
This pull request has been merged in 05ba810. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Internal tests will never catch the use of Python features
(like the pipe operator on types without
__future__.annotations)that are incompatible with older versions of Python that we still
need to support.
As a result it's very important that we cover this in gituhub tests;
even though we frequently break CI, this at least makes it easy to
prep for an open-source release: first check CI for test failures
on any supported Python version and fix issues, only then start a
release.
Unfortunately the script wasn't running upgrade tests, and as a result
didn't catch an invalid use of the pipe operator in unguarded type
annotations.
Differential Revision: D57218140