move to the upstream helm #1441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69c74f5 to
f8810c5
Compare
shlomitk1
reviewed
Apr 25, 2022
shlomitk1
previously approved these changes
Apr 25, 2022
revit13
reviewed
Apr 28, 2022
| @@ -22,7 +22,6 @@ HELM_TAG ?= 0.0.0 | |||
|
|
|||
| CHART_REGISTRY_PATH := oci://${DOCKER_HOSTNAME}/${DOCKER_NAMESPACE} | |||
|
|
|||
| export HELM_EXPERIMENTAL_OCI=1 | |||
| export GODEBUG=x509ignoreCN=0 | |||
There was a problem hiding this comment.
for versions lower than 3.8 HELM_EXPERIMENTAL_OCI is needed and as DESIRED_VERSION can change I suggest keeping HELM_EXPERIMENTAL_OCI
There was a problem hiding this comment.
Why will somebody use the old version?
Signed-off-by: Alexey Roytman <roytman@il.ibm.com>
Signed-off-by: Alexey Roytman <roytman@il.ibm.com>
Signed-off-by: Alexey Roytman <roytman@il.ibm.com>
revit13
approved these changes
Apr 28, 2022
This was referenced May 1, 2022
zivnevo
pushed a commit
to zivnevo/fybrik
that referenced
this pull request
May 17, 2022
* move to the upstream helm Signed-off-by: Alexey Roytman <roytman@il.ibm.com> Signed-off-by: Ziv Nevo <nevo@il.ibm.com>
roytman
added a commit
to roytman/fybrik
that referenced
this pull request
Jun 15, 2022
Signed-off-by: Alexey Roytman <roytman@il.ibm.com>
roytman
added a commit
that referenced
this pull request
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move to the upstream helm repo.
Bump to upstream helm 3.8.2 plus update a list of other third-party dependencies.
/closes #1443
/closes #1219
Signed-off-by: Alexey Roytman roytman@il.ibm.com