Set helm version to 3.8 #1219
Closed
Set helm version to 3.8 #1219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72c33a1 to
dbd91fd
Compare
ngoracke
reviewed
Feb 2, 2022
site/docs/get-started/quickstart.md
Outdated
| @@ -44,7 +44,7 @@ Many clusters already include cert-manager. Check if `cert-manager` namespace ex | |||
| ```bash | |||
| helm install cert-manager jetstack/cert-manager \ | |||
| --namespace cert-manager \ | |||
| --version v1.2.0 \ | |||
| --version v1.6.0 \ | |||
There was a problem hiding this comment.
Right. this PR does not include documentation changes yet.
ngoracke
reviewed
Feb 2, 2022
third_party/cert-manager/Makefile
Outdated
| @@ -10,7 +10,7 @@ deploy: $(TOOLBIN)/kubectl $(TOOLBIN)/helm | |||
| $(TOOLBIN)/kubectl create namespace cert-manager | |||
| $(TOOLBIN)/helm repo add jetstack https://charts.jetstack.io | |||
| $(TOOLBIN)/helm repo update | |||
| $(TOOLBIN)/helm install cert-manager jetstack/cert-manager --version v1.2.0 \ | |||
| $(TOOLBIN)/helm install cert-manager jetstack/cert-manager --version v1.6.2 \ | |||
There was a problem hiding this comment.
This task in pipeline/pipeline.yaml should be updated I think.
- name: upgrade-helm-certmgr-from-repo
params:- name: helm_repo
value: https://charts.jetstack.io - name: chart_name
value: jetstack/cert-manager --create-namespace - name: release_version
value: v1.2.0 - name: release_name
value: cert-manager - name: release_namespace
value: cert-manager - name: overwrite_values
value: installCRDs=true - name: image
value: $(params.helm_image)
taskRef:
kind: Task
name: helm-upgrade-from-repo
workspaces: - name: source
workspace: shared-workspace
when: - Input: $(params.deployCertManager)
Operator: in
Values:- "true"
- Input: $(params.IMAGE_DIGEST)
Operator: in
Values:- "none"
- Input: $(params.INCREMENTAL_RESTART)
- name: helm_repo
ngoracke
reviewed
Feb 2, 2022
hack/tools/create_kind.sh
Outdated
| @@ -8,7 +8,7 @@ op=$1 | |||
|
|
|||
| source ./common.sh | |||
|
|
|||
| K8S_VERSION=${K8S_VERSION:-v1.19.11@sha256:07db187ae84b4b7de440a73886f008cf903fcf5764ba8106a9fd5243d6f32729} | |||
| K8S_VERSION=${K8S_VERSION:-v1.22.0@sha256:b8bda84bb3a190e6e028b1760d277454a72267a5454b57db34437c34a588d047} | |||
There was a problem hiding this comment.
out of curiousity, why is this upgrade required?
Sorry, something went wrong.
There was a problem hiding this comment.
it was a BU requirement to support K8s 1.22.x. OpenShift 4.9 runs on it.
|
Can't view the tekton status currently, (getting 500 errors when clicking on the link), but I'll review that when it's back |
62da9d6 to
0bca40d
Compare
|
From the latest result, the service policy manager build, opa, manager, katalog, and datacatalog is failing: |
|
@ngoracke , probably the error is related to kubernetes-sigs/json#8 |
Signed-off-by: Revital Sur <eres@il.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #1215 as Helm 3.8 is compatible with K8s v1.20-v1.23 according to https://helm.sh/docs/topics/version_skew/
Closes #1217