Inkplate 6 support for ESPHome #1283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inkplate 6 is e-paper display based on ESP32. This commit adds support for integrating Inkplate 6 into the ESPHome. Find more info here: inkplate.io
2 tasks
Attempt to fix formatting errors
2 tasks
jesserockz
reviewed
Sep 22, 2020
|
@glmnet @OttoWinter Any advice on what to do with the |
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
jesserockz
reviewed
Sep 22, 2020
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
OttoWinter
reviewed
Oct 4, 2020
| cv.Required(CONF_SPV_PIN): pins.gpio_output_pin_schema, | ||
| cv.Required(CONF_VCOM_PIN): pins.gpio_output_pin_schema, | ||
| cv.Required(CONF_WAKEUP_PIN): pins.gpio_output_pin_schema, | ||
| cv.Optional(CONF_CL_PIN, default=0): pins.internal_gpio_output_pin_schema, |
There was a problem hiding this comment.
Why are there default values here?
Also these config options don't appear to be documented in the docs (which they should)
There was a problem hiding this comment.
The defaults are there because you cant change the hardwired pins for the Inkplate, which then saves on adding more yaml config. Can be removed if too much though?
OttoWinter
reviewed
Oct 4, 2020
OttoWinter
reviewed
Oct 4, 2020
OttoWinter
reviewed
Oct 4, 2020
|
|
||
| this->buffer_ = (uint8_t *) ps_malloc(buffer_size); | ||
| if (this->buffer_ == nullptr) { | ||
| ESP_LOGE(TAG, "Could not allocate buffer for display!"); |
There was a problem hiding this comment.
If allocation fails, shouldn't we return from this method?
Ignore some lint errors Only allow on ESP32
Lint errors etc
Update the codeowners file
jesserockz
approved these changes
Jan 13, 2021
|
Phef, finally, very nice! Thanks on your assistance, Jesse. |
jesserockz
added a commit
that referenced
this pull request
Jan 17, 2021
* Add Inkplate 6 support Inkplate 6 is e-paper display based on ESP32. This commit adds support for integrating Inkplate 6 into the ESPHome. Find more info here: inkplate.io * Greyscale working * Update inkplate.h * Fix formatting * Formatting * Update esphome/components/inkplate6/display.py Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com> * Update esphome/components/inkplate6/display.py Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com> * Fix some lint errors Ignore some lint errors Only allow on ESP32 * Update the codeowners file Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
Merged
micronen
pushed a commit
to micronen/esphome
that referenced
this pull request
Feb 5, 2021
* Add Inkplate 6 support Inkplate 6 is e-paper display based on ESP32. This commit adds support for integrating Inkplate 6 into the ESPHome. Find more info here: inkplate.io * Greyscale working * Update inkplate.h * Fix formatting * Formatting * Update esphome/components/inkplate6/display.py Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com> * Update esphome/components/inkplate6/display.py Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com> * Fix some lint errors Ignore some lint errors Only allow on ESP32 * Update the codeowners file Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Inkplate 6 is e-paper ESP32 based display. This PR enables its usage with ESPHome.
Related issue (if applicable): fixes
**Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#778
Checklist:
tests/folder).If user exposed functionality or configuration variables are added/changed: