-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Adding Inkplate 6 docs #778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks @nitko12
Jesse |
Thank you @jesserockz ! What should I write in configuration options? |
@nitko12 yeah looks good. Using the same layout as the other display docs: Add a simple explanation for the all of the config options available for the display component. You can copy the description of the common options from the other displays. |
@jesserockz is it okay now? |
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
Looking better. Maybe add a note somewhere about partial updating being ignored when greyscale is used? |
Added that, so were set to merge now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think so. It will be merged at the same time as esphome/esphome#1283
components/display/Inkplate.rst
Outdated
|
||
All-in-one e-paper display ``Inkplate 6`` | ||
Inkplate 6 is a powerful, Wi-Fi enabled ESP32 based six-inch e-paper display – recycled from a Kindle e-reader. Its main feature is simplicity. | ||
Learn more at `our website <https://inkplate.io/>`__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please write inkplate's
website instead. I don't want to give the impression that ESPHome is somehow directly related to inkplate (users viewing the docs won't look who made the docs PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done that :D
Not sure how the status on this is, but reading the battery voltage from the example doesn't work on my Inkplate. Adding something for the battery sensor would be nice too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes to fix battery voltage example
* Added Inkplate. * Fixing Inkplate docs. * Added Configuration variables for Inkplate. * Update components/display/Inkplate.rst Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com> * Added another warning. * Fixed indents. * Done requested change * Add pin configurations to docs * Apply suggestions from code review Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
Description:
Changed branch from #768 PR.
Pull request in esphome with YAML changes (if applicable): esphome/esphome#1283
Checklist:
next
is for changes and new documentation that will go public with the next ESPHome release. Fixes, changes and adjustments for the current release should be created againstcurrent
./index.rst
when creating new documents for new components or cookbook.