Replaced group_by_namespace/1 by a call to maps:groups_from_list/2 #2895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Since the bump to R25, group_by_namespace/1 follows only branch of the macro * group_by_namespace/1 occurs once in apps/rebar/src/rebar_prv_completion.erl
ferd
approved these changes
Jun 4, 2024
heyoka
pushed a commit
to heyoka/faxe
that referenced
this pull request
Mar 18, 2025
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [erlang/rebar3](https://github.com/erlang/rebar3) | minor | `3.22.0` -> `3.24.0` | --- >⚠️ **Warning** > > Some dependencies could not be looked up. Check the warning logs for more information. --- ### Release Notes <details> <summary>erlang/rebar3 (erlang/rebar3)</summary> ### [`v3.24.0`](https://github.com/erlang/rebar3/releases/tag/3.24.0) [Compare Source](erlang/rebar3@3.23.0...3.24.0) New features: - [Turn rich compiler errors on by default](erlang/rebar3#2881) - [Tweak experimental manifest plugin to return ELP-compatible information](erlang/rebar3#2910) Bug fixes: - [make escriptize reproducible by setting timestamps for files in zip to unix epoch](erlang/rebar3#2900) - [Log path when plugin template file read fails](erlang/rebar3#2899) - [Prevent infinite compiler DAG growth](erlang/rebar3#2892) - [Port Relx compatibility fix for escript files in OTP-27](erlang/rebar3@26cd527) Internal maintenance: - [Made `rebar_utils:filtermap/2` to call directly `lists:filtermap/2`](erlang/rebar3#2907) - [Cleaned up additional definitions in `bootstrap`](erlang/rebar3#2905) - [Replaced rebar_utils:find_source/3 by a call to filelib:find_source/3](erlang/rebar3#2904) and [Marked rebar_utils:find_source/3 as deprecated](erlang/rebar3#2901) - [Fixing various typos in comments, types, and function names](erlang/rebar3#2902) - [Bump hex_core and certifi dependencies](erlang/rebar3#2898) - [Remove legacy hostname checks](erlang/rebar3#2896) - [Replaced group_by_namespace/1 by a call to maps:groups_from_list/2](erlang/rebar3#2895) - [Removed legacy OTP_RELEASE macro statements](erlang/rebar3#2891) - [Removed legacy fun_stacktrace usage](erlang/rebar3#2889) - [Removed unsused platform_define options](erlang/rebar3#2888) - [Standardizing templates indentation](erlang/rebar3#2884) Regarding rich compiler errors, the change is optional. Given the module: -module(fake_mod). -export([diagnostic/1]). diagnostic(A) -> X = add(5 / 0), {X,X}. add(X) -> X. add(X, Y) -> X + Y. Calling rebar3 compile can now yield: ... ===> Compiling apps/rebar/src/fake_mod.erl failed ┌─ apps/rebar/src/fake_mod.erl: │ 5 │ diagnostic(A) -> │ ╰── variable 'A' is unused ┌─ apps/rebar/src/fake_mod.erl: │ 6 │ X = add(5 / 0), │ ╰── evaluati...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
group_by_namespace/1follows only branch of the macrogroup_by_namespace/1occurs once inapps/rebar/src/rebar_prv_completion.erl