8000 Removed fun_stacktrace by ariel-anieli · Pull Request #2889 · erlang/rebar3 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Removed fun_stacktrace #2889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

ariel-anieli
Copy link
@ariel-anieli ariel-anieli commented May 21, 2024

@ariel-anieli ariel-anieli force-pushed the deprecated-fun-stacktrace branch from 05d4a70 to 8c0b67e Compare May 21, 2024 19:05
* introduced by 5f9b429
* CI/CD uses R24 and onwards
* erlang:get_stacktrace/0 removed in R23.

[1] https://erlang.org/documentation/doc-12.0-rc2/doc/general_info/removed.html#functions-removed-in-otp-23
@ariel-anieli ariel-anieli force-pushed the deprecated-fun-stacktrace branch from 8c0b67e to 58be63e Compare May 21, 2024 19:40
Copy link
Collaborator
@ferd ferd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I need to look at bumping us to 27.0 soon, which means ratcheting up the min version to 25.x

@ferd ferd merged commit 4594b00 into erlang:main May 21, 2024
6 checks passed
@ariel-anieli ariel-anieli deleted the deprecated-fun-stacktrace branch May 22, 2024 13:46
@ariel-anieli
Copy link
Author

Makes sense. I need to look at bumping us to 27.0 soon, which means ratcheting up the min version to 25.x

🙂 Thank you. I am looking forward that bump.

heyoka pushed a commit to heyoka/faxe that referenced this pull request Mar 18, 2025
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [erlang/rebar3](https://github.com/erlang/rebar3) | minor | `3.22.0` -> `3.24.0` |

---

> ⚠️ **Warning**
>
> Some dependencies could not be looked up. Check the warning logs for more information.

---

### Release Notes

<details>
<summary>erlang/rebar3 (erlang/rebar3)</summary>

### [`v3.24.0`](https://github.com/erlang/rebar3/releases/tag/3.24.0)

[Compare Source](erlang/rebar3@3.23.0...3.24.0)

New features:

-   [Turn rich compiler errors on by default](erlang/rebar3#2881)
-   [Tweak experimental manifest plugin to return ELP-compatible information](erlang/rebar3#2910)

Bug fixes:

-   [make escriptize reproducible by setting timestamps for files in zip to unix epoch](erlang/rebar3#2900)
-   [Log path when plugin template file read fails](erlang/rebar3#2899)
-   [Prevent infinite compiler DAG growth](erlang/rebar3#2892)
-   [Port Relx compatibility fix for escript files in OTP-27](erlang/rebar3@26cd527)

Internal maintenance:

-   [Made `rebar_utils:filtermap/2` to call directly `lists:filtermap/2`](erlang/rebar3#2907)
-   [Cleaned up additional definitions in `bootstrap`](erlang/rebar3#2905)
-   [Replaced rebar_utils:find_source/3 by a call to filelib:find_source/3](erlang/rebar3#2904) and [Marked rebar_utils:find_source/3 as deprecated](erlang/rebar3#2901)
-   [Fixing various typos in comments, types, and function names](erlang/rebar3#2902)
-   [Bump hex_core and certifi dependencies](erlang/rebar3#2898)
-   [Remove legacy hostname checks](erlang/rebar3#2896)
-   [Replaced group_by_namespace/1 by a call to maps:groups_from_list/2](erlang/rebar3#2895)
-   [Removed legacy OTP_RELEASE macro statements](erlang/rebar3#2891)
-   [Removed legacy fun_stacktrace usage](erlang/rebar3#2889)
-   [Removed unsused platform_define options](erlang/rebar3#2888)
-   [Standardizing templates indentation](erlang/rebar3#2884)

Regarding rich compiler errors, the change is optional.

Given the module:

    -module(fake_mod).

    -export([diagnostic/1]).

    diagnostic(A) ->
        X = add(5 / 0),
        {X,X}.

    add(X) -> X.

    add(X, Y) -> X + Y.

Calling rebar3 compile can now yield:

    ...
    ===> Compiling apps/rebar/src/fake_mod.erl failed
       ┌─ apps/rebar/src/fake_mod.erl:
       │
     5 │  diagnostic(A) ->
       │             ╰── variable 'A' is unused

       ┌─ apps/rebar/src/fake_mod.erl:
       │
     6 │      X = add(5 / 0),
       │                ╰── evaluati...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0