8000 fix: devtools allow restoring saved dock state on Windows by deepak1556 · Pull Request #39734 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: devtools allow restoring saved dock state on Windows #39734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 7, 2023
Merged

fix: devtools allow restoring saved dock state on Windows #39734

merged 2 commits into from
Sep 7, 2023

Conversation

deepak1556
Copy link
Member

Description of Change

#35209 defaulted to detach position when opening devtools without any predefined state to workaround a bug in chromium, this took away the docking feature of devtools on Windows. #35754 was later added to respect the state option when opening devtools, although it is a good enough solution it takes away the option to rely on preferred dock state persisted to user data dir when opening devtools without any arguments.

This PR attempts to respect the persisted preferred dock state when WCO is enabled on Windows and instead of detaching the devtools it will now undock depending the dock state corresponding to the position of window controls. This allows users to still have control over the dock position without the application enforcing it.

Needed for microsoft/vscode#168454

Release Notes

Notes: fix devtools to allow restoring saved dock state on Windows

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Sep 5, 2023
@deepak1556 deepak1556 added semver/patch backwards-compatible bug fixes target/25-x-y PR should also be added to the "25-x-y" branch. target/26-x-y PR should also be added to the "26-x-y" branch. target/27-x-y PR should also be added to the "27-x-y" branch. labels Sep 5, 2023
@bpasero bpasero mentioned this pull request Sep 5, 2023
Closed
codebytere
codebytere reviewed Sep 5, 2023
View reviewed changes
@deepak1556 deepak1556 force-pushed the robo/fix_default_dock_pos_win branch from 50a7680 to c152b61 Compare September 6, 2023 02:29
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Sep 6, 2023
@codebytere codebytere force-pushed the robo/fix_default_dock_pos_win branch from c152b61 to e017d68 Compare September 6, 2023 12:25
@deepak1556
Copy link
Member Author

Failing tests are unrelated, merging.

@deepak1556 deepak1556 merged commit 0a064ce into main Sep 7, 2023
@deepak1556 deepak1556 deleted the robo/fix_default_dock_pos_win branch September 7, 2023 08:14
@release-clerk
Copy link
release-clerk bot commented Sep 7, 2023

Release Notes Persisted

fix devtools to allow restoring saved dock state on Windows

@trop trop bot mentioned this pull request Sep 7, 2023
Merged
@trop
Copy link
Contributor
trop bot commented Sep 7, 2023

I have automatically backported this PR to "25-x-y", please check out #39766

@trop trop bot added the in-flight/25-x-y label Sep 7, 2023
@trop trop bot mentioned this pull request Sep 7, 2023
Merged
@trop trop bot removed the target/25-x-y PR should also be added to the "25-x-y" branch. label Sep 7, 2023
@trop trop bot mentioned this pull request Sep 7, 2023
Merged
@trop
Copy link
Contributor
trop bot commented Sep 7, 2023

I have automatically backported this PR to "27-x-y", please check out #39767

@trop
Copy link
Contributor
trop bot commented Sep 7, 2023

I have automatically backported this PR to "26-x-y", please check out #39768

@trop trop bot added in-flight/27-x-y in-flight/26-x-y and removed target/27-x-y PR should also be added to the "27-x-y" branch. labels Sep 7, 2023
@trop trop bot added merged/27-x-y PR was merged to the "27-x-y" branch. merged/26-x-y PR was merged to the "26-x-y" branch. merged/25-x-y PR was merged to the "25-x-y" branch. and removed target/26-x-y PR should also be added to the "26-x-y" branch. in-flight/27-x-y in-flight/26-x-y labels Sep 7, 2023
@theolivenbaum theolivenbaum mentioned this pull request Sep 17, 2023
Closed
3 tasks
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@deepak1556
fix: devtools allow restoring saved dock state on Windows (electron#3…
942ae98 
…9734)

* fix: devtools allow restoring saved dock state on Windows

* chore: address feedback
@deepak1556 deepak1556 mentioned this pull request Aug 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
merged/25-x-y PR was merged to the "25-x-y" branch. merged/26-x-y PR was merged to the "26-x-y" branch. merged/27-x-y PR was merged to the "27-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deepak1556 @zcbenz @codebytere
0