8000 fix: WCO occlusion of DevTools by codebytere · Pull Request #35209 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: WCO occlusion of DevTools #35209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2022
Merged

fix: WCO occlusion of DevTools #35209

merged 1 commit into from
Aug 11, 2022

Conversation

codebytere
Copy link
Member
@codebytere codebytere commented Aug 3, 2022 •
edited
Loading

Description of Change

Closes #34129.

This change matches Chromium behavior for WCO by opening DevTools in detached mode if WCO is enabled.
This prevents the DevTools from being occluded and becoming semi-unusable.

Before Screen Shot 2022-08-03 at 4 21 38 PM
After Screen Shot 2022-08-03 at 4 21 52 PM

Checklist

Release Notes

Notes: Fixed an issue where WCO could occlude DevTools opened in any non-detached mode.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Aug 3, 2022
@codebytere codebytere added the semver/patch backwards-compatible bug fixes label Aug 4, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Aug 4, 2022
@codebytere codebytere force-pushed the match-chrome-wco-devtools branch from 2743e4f to fac1fb9 Compare August 9, 2022 07:38
@codebytere codebytere force-pushed the match-chrome-wco-devtools branch from fac1fb9 to f35390b Compare August 10, 2022 07:49
@codebytere codebytere merged commit 4d54cad into main Aug 11, 2022
@codebytere codebytere deleted the match-chrome-wco-devtools branch August 11, 2022 13:16
@release-clerk
Copy link
release-clerk bot commented Aug 11, 2022

Release Notes Persisted

Fixed an issue where WCO could occlude DevTools opened in any non-detached mode.

This was referenced Aug 11, 2022
Merged
Merged
Merged
@trop
Copy link
Contributor
trop bot commented Aug 11, 2022

I have automatically backported this PR to "18-x-y", please check out #35307

@trop
Copy link
Contributor
trop bot commented Aug 11, 2022

I have automatically backported this PR to "19-x-y", please check out #35308

@trop
Copy link
Contributor
trop bot commented Aug 11, 2022

I have automatically backported this PR to "20-x-y", please check out #35309

@miniak miniak mentioned this pull request Sep 15, 2022
Merged
2 tasks
@miniak
Copy link
Contributor
miniak commented Sep 15, 2022

/trop run backport-to 21-x-y

@trop
Copy link
Contributor
trop bot commented Sep 15, 2022

The backport process for this PR has been manually initiated - sending your PR to 21-x-y!

@trop trop bot mentioned this pull request Sep 15, 2022
Merged
@trop
Copy link
Contributor
trop bot commented Sep 15, 2022

I have automatically backported this PR to "21-x-y", please check out #35688

@trop trop bot added in-flight/21-x-y merged/21-x-y PR was merged to the "21-x-y" branch. and removed in-flight/21-x-y labels Sep 15, 2022
@whzard whzard mentioned this pull request Sep 18, 2022
Closed
3 tasks
@codebytere codebytere mentioned this pull request Sep 21, 2022
Merged
3 tasks
@commit-lint commit-lint bot mentioned this pull request Oct 24, 2022
Open
schetle pushed a commit to schetle/electron that referenced this pull request Nov 3, 2022
@codebytere @schetle
fix: WCO occlusion of DevTools (electron#35209)
37230fa
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@codebytere @khalwa
fix: WCO occlusion of DevTools (electron#35209)
8000
82d635b
@deepak1556 deepak1556 mentioned this pull request Sep 5, 2023
Merged
@Jervx Jervx mentioned this pull request Aug 14, 2024
Open
@fireattack
Copy link

So when the user manually dock the devtool to the right side, it would still be occluded (see microsoft/vscode#168454 (comment)). Is there any plan to actually fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@clavin clavin Awaiting requested review from clavin

@mlaurencin mlaurencin Awaiting requested review from mlaurencin

Assignees
No one assigned
Labels
merged/21-x-y PR was merged to the "21-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: WCO on Windows occludes dev tools
6 participants
@codebytere @miniak @fireattack @zcbenz @VerteDinde @MarshallOfSound
0