8000 fix: persist permission granted to serial ports by jkleinsc · Pull Request #31190 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: persist permission granted to serial ports #31190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2021
Merged

fix: persist permission granted to serial ports #31190

merged 1 commit into from
Oct 4, 2021

Conversation

jkleinsc
Copy link
Member
@jkleinsc jkleinsc commented Sep 29, 2021 •
edited
Loading

Backport of #30209

See that PR for details.

This PR uses the approach taken in #31181 to resolve the issue but does not introduce a new API like #31181 does.

Notes: Fixed navigator.serial.getPorts() to return previously selected ports.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Sep 29, 2021
@trop trop bot mentioned this pull request Sep 29, 2021
Merged
3 tasks
@trop trop bot added 13-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Sep 29, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Sep 29, 2021
@jkleinsc jkleinsc force-pushed the remember-saved-serial-13 branch from a384c7a to b36aaa8 Compare September 29, 2021 15:41
@trop trop bot added semver/patch backwards-compatible bug fixes and removed semver/patch backwards-compatible bug fixes labels Sep 29, 2021
@zcbenz zcbenz merged commit 044c980 into 13-x-y Oct 4, 2021
@zcbenz zcbenz deleted the remember-saved-serial-13 branch October 4, 2021 01:09
@release-clerk
Copy link
release-clerk bot commented Oct 4, 2021

Release Notes Persisted

Fixed navigator.serial.getPorts() to return previously selected ports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
13-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkleinsc @zcbenz
0