8000 chore: refactor persisting permission granted to serial ports by jkleinsc · Pull Request #31181 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: refactor persisting permission granted to serial ports #31181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2021
Merged

chore: refactor persisting permission granted to serial ports #31181

merged 1 commit into from
Oct 6, 2021

Conversation

jkleinsc
Copy link
Member
@jkleinsc jkleinsc commented Sep 29, 2021 •
edited
Loading

Description of Change

This is a refactor of #30209 to use the same permissioning that was implemented for WebHID.

Checklist

Release Notes

Notes: Changed Web Serial to use ses.setDevicePermissionHandler to allow developers more control over Web Serial permissioning.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Sep 29, 2021
@jkleinsc jkleinsc added the semver/minor backwards-compatible functionality label Sep 29, 2021
This was referenced Sep 29, 2021
Merged
Closed
Merged
Merged
zcbenz
zcbenz approved these changes Oct 4, 2021
View reviewed changes
Copy link
Contributor
@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API looks good to me.

@jkleinsc jkleinsc removed the new-pr 🌱 PR opened recently label Oct 4, 2021
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Oct 4, 2021
@jkleinsc jkleinsc removed new-pr 🌱 PR opened recently target/14-x-y labels Oct 4, 2021
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Oct 4, 2021
@jkleinsc jkleinsc added target/14-x-y and removed new-pr 🌱 PR opened recently labels Oct 4, 2021
@electron-cation electron-cation bot added new-pr 🌱 PR opened recently and removed new-pr 🌱 PR opened recently labels Oct 4, 2021
ckerr
ckerr approved these changes Oct 6, 2021
View reviewed changes
Copy link
Member
@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API changes look fine

@jkleinsc jkleinsc merged commit d6de243 into main Oct 6, 2021
@jkleinsc jkleinsc deleted the fixup-serial-permissioning branch October 6, 2021 20:18
@release-clerk
Copy link
release-clerk bot commented Oct 6, 2021

Release Notes Persisted

Changed Web Serial to use ses.setDevicePermissionHandler to allow developers more control over Web Serial permissioning.

@trop
Copy link
Contributor
trop bot commented Oct 6, 2021

I was unable to backport this PR to "14-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/14-x-y label Oct 6, 2021
@trop
Copy link
Contributor
trop bot commented Oct 6, 2021

I was unable to backport this PR to "15-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot mentioned this pull request Oct 6, 2021
Merged
@trop
Copy link
Contributor
trop bot commented Oct 6, 2021

I have automatically backported this PR to "16-x-y", please check out #31324

@jkleinsc jkleinsc mentioned this pull request Oct 13, 2021
Merged
@trop
Copy link
Contributor
trop bot commented Oct 13, 2021

@jkleinsc has manually backported this PR to "15-x-y", please check out #31418

@trop trop bot mentioned this pull request Oct 15, 2021
Merged
t57ser pushed a commit to t57ser/electron that referenced this pull request Oct 27, 2021
@jkleinsc @t57ser
chore: refactor persisting permission granted to serial ports (electr…
2c6ce16 
…on#31181)
t57ser pushed a commit to t57ser/electron that referenced this pull request Oct 27, 2021
@jkleinsc @t57ser
chore: refactor persisting permission granted to serial ports (electr…
936a30a 
…on#31181)
t57ser pushed a commit to t57ser/electron that referenced this pull request Oct 29, 2021
@jkleinsc @t57ser
chore: refactor persisting permission granted to serial ports (electr…
6c6a478 
…on#31181)
t57ser pushed a commit to t57ser/electron that referenced this pull request Oct 29, 2021
@jkleinsc @t57ser
chore: refactor persisting permission granted to serial ports (electr…
f0d24dc 
…on#31181)
t57ser pushed a commit to t57ser/electron that referenced this pull request Oct 29, 2021
@jkleinsc @t57ser
chore: refactor persisting permission granted to serial ports (electr…
e917fc7 
…on#31181)
t57ser pushed a commit to t57ser/electron that referenced this pull request Oct 29, 2021
@jkleinsc @t57ser
chore: refactor persisting permission granted to serial ports (electr…
942b7a2 
…on#31181)
@commit-lint commit-lint bot mentioned this pull request Jan 11, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
api-review/requested 🗳 semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jkleinsc @ckerr @zcbenz @codebytere
0