8000 fix: allow colored tray titles when font type is specified by trop[bot] · Pull Request #30162 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: allow colored tray titles when font type is specified #30162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

trop[bot]
Copy link
Contributor
@trop trop bot commented Jul 15, 2021

Backport of #30146

See that PR for details.

Notes: Fixed tray.setTitle not respecting ANSI colors if a font type was specified.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jul 15, 2021
@trop trop bot requested a review from nornagon July 15, 2021 23:45
@trop trop bot added 12-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jul 15, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jul 15, 2021
@nornagon
Copy link
Contributor

Actually, closing because 12.x is security fixes only now.

@nornagon nornagon closed this Jul 26, 2021
@trop trop bot deleted the trop/12-x-y-bp-fix-allow-colored-tray-titles-when-font-type-is-specified-1626392736182 branch July 26, 2021 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
12-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0