8000 fix: allow colored tray titles when font type is specified by nornagon · Pull Request #30146 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: allow colored tray titles when font type is specified #30146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2021
Merged

fix: allow colored tray titles when font type is specified #30146

merged 1 commit into from
Jul 15, 2021

Conversation

nornagon
Copy link
Contributor

Description of Change

Fixes #29287.

Checklist

Release Notes

Notes: Fixed tray.setTitle not respecting ANSI colors if a font type was specified.

@nornagon nornagon added semver/patch backwards-compatible bug fixes target/12-x-y labels Jul 14, 2021
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jul 14, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jul 15, 2021
@nornagon nornagon merged commit 0d9e6f2 into main Jul 15, 2021
@nornagon nornagon deleted the color-tray-attribute branch July 15, 2021 23:45
@release-clerk
Copy link
release-clerk bot commented Jul 15, 2021

Release Notes Persisted

Fixed tray.setTitle not respecting ANSI colors if a font type was specified.

@commit-lint commit-lint bot mentioned this pull request Jul 15, 2021
Merged
This was referenced Jul 15, 2021
Closed
Merged
Merged
@trop
Copy link
Contributor
trop bot commented Jul 15, 2021

I have automatically backported this PR to "12-x-y", please check out #30162
8000

@trop
Copy link
Contributor
trop bot commented Jul 15, 2021

I have automatically backported this PR to "13-x-y", please check out #30163

@trop
Copy link
Contributor
trop bot commented Jul 15, 2021

I have automatically backported this PR to "14-x-y", please check out #30164

BlackHole1 pushed a commit to BlackHole1/electron that referenced this pull request Aug 30, 2021
@nornagon @BlackHole1
fix: allow colored tray titles when font type is specified (electron#…
c4e3d52 
…30146)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Tray title ANSI colors don't work when using fontType option
2 participants
@nornagon @codebytere
0