8000 fix: set WebContents background color ubiquitously by codebytere · Pull Request #27945 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: set WebContents background color ubiquitously #27945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2021
Merged

fix: set WebContents background color ubiquitously #27945

merged 1 commit into from
Mar 1, 2021

Conversation

codebytere
Copy link
Member

Backport of #27593.

See that PR for details.

Notes: Fixed background color not being applied for child windows created by native window.open path.

@marekharanczyk @codebytere
fix: set WebContents background color ubiquitously
a708676 
Move it from LoadURL to RenderViewCreated which is present
in all window creation cases and is called early enough to be
relevant from user prespective and after RenderWidgetHostView
is already present.
@codebytere codebytere requested a review from a team March 1, 2021 18:29
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Mar 1, 2021
@trop trop bot mentioned this pull request Mar 1, 2021
Merged
3 tasks
@trop trop bot added 10-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Mar 1, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Mar 1, 2021
@codebytere codebytere merged commit a64d071 into 10-x-y Mar 1, 2021
@codebytere codebytere deleted the background-color-10 branch March 1, 2021 21:21
@release-clerk
Copy link
release-clerk bot commented Mar 1, 2021

Release Notes Persisted

Fixed background color not being applied for child windows created by native window.open path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
10-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codebytere @jkleinsc @marekharanczyk
0