8000 fix: set WebContents background color ubiquitously by marekharanczyk · Pull Request #27593 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: set WebContents background color ubiquitously #27593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2021
Merged

fix: set WebContents background color ubiquitously #27593

merged 1 commit into from
Feb 10, 2021

Conversation

marekharanczyk
Copy link
Contributor

Move it from LoadURL to RenderViewCreated which is present
in all window creation cases and is called early enough to be
relevant from UX perspective but after RenderWidgetHostView
is already present.

Description of Change

Checklist

Release Notes

Notes: Fixed background color not being applied for child windows created by native window.open path.

@welcome
Copy link
welcome bot commented Feb 2, 2021

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Feb 2, 2021
MarshallOfSound
MarshallOfSound reviewed Feb 2, 2021
View reviewed changes
@marekharanczyk marekharanczyk force-pushed the background_color_cleanup branch from e4863f9 to 2778d3a Compare February 5, 2021 08:46
@zcbenz zcbenz added semver/patch backwards-compatible bug fixes target/10-x-y labels Feb 8, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Feb 8, 2021
@codebytere codebytere changed the title fix: set WebContents background color ubiquitously #27592 fix: set WebContents background color ubiquitously Feb 9, 2021
@codebytere
Copy link
10000 Member

@marekharanczyk can you please rebase this?

@marekharanczyk
fix: set WebContents background color ubiquitously electron#27592
08523b4 
Move it from LoadURL to RenderViewCreated which is present
in all window creation cases and is called early enough to be
relevant from user prespective and after RenderWidgetHostView
is already present.
@marekharanczyk marekharanczyk force-pushed the background_color_cleanup branch from 2778d3a to 08523b4 Compare February 10, 2021 16:14
@marekharanczyk
Copy link
Contributor Author

Rebase done.

@codebytere
Copy link
Member

Failure is unrelated.

@codebytere codebytere merged commit 87064e5 into electron:master Feb 10, 2021
@welcome
Copy link
welcome bot commented Feb 10, 2021

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link
release-clerk bot commented Feb 10, 2021

Release Notes Persisted

Fixed background color not being applied for child windows created by native window.open path.

@trop
Copy link
Contributor
trop bot commented Feb 10, 2021

I was unable to backport this PR to "10-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor
trop bot commented Feb 10, 2021

I was unable to backport this PR to "12-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor
trop bot commented Feb 10, 2021

I was unable to backport this PR to "11-x-y" cleanly;
you will need to perform this backport manually.

codebytere pushed a commit that referenced this pull request Mar 1, 2021
@marekharanczyk @codebytere
fix: set WebContents background color ubiquitously #27592 (#27593)
8d5ddf2 
Move it from LoadURL to RenderViewCreated which is present
in all window creation cases and is called early enough to be
relevant from user prespective and after RenderWidgetHostView
is already present.
@codebytere codebytere mentioned this pull request Mar 1, 2021
Merged
@trop
Copy link
Contributor
trop bot commented Mar 1, 2021

@codebytere has manually backported this PR to "12-x-y", please check out #27942

@codebytere codebytere mentioned this pull request Mar 1, 2021
Merged
@trop
Copy link
Contributor
trop bot commented Mar 1, 2021

@codebytere has manually backported this PR to "11-x-y", please check out #27944

@codebytere codebytere mentioned this pull request Mar 1, 2021
Merged
@trop
Copy link
Contributor
trop bot commented Mar 1, 2021

@codebytere has manually backported this PR to "10-x-y", please check out #27945

MarshallOfSound pushed a commit that referenced this pull request Mar 1, 2021
@codebytere @marekharanczyk
fix: set WebContents background color ubiquitously #27592 (#27593) (#…
fd629c1 
…27942)

Move it from LoadURL to RenderViewCreated which is present
in all window creation cases and is called early enough to be
relevant from user prespective and after RenderWidgetHostView
is already present.

Co-authored-by: marekharanczyk <48673767+marekharanczyk@users.noreply.github.com>
This was referenced Mar 5, 2021
Closed
Closed
@dependabot dependabot bot mentioned this pull request Mar 8, 2021
Closed
@nornagon nornagon mentioned this pull request Apr 2, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound left review comments

@zcbenz zcbenz zcbenz approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marekharanczyk @codebytere @zcbenz @MarshallOfSound
0