8000 fix: reject contentTracing.stopRecording on failure by trop[bot] · Pull Request #26656 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: reject contentTracing.stopRecording on failure #26656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 23, 2020
Merged

fix: reject contentTracing.stopRecording on failure #26656

merged 2 commits into from
Nov 23, 2020

Conversation

trop[bot]
Copy link
Contributor
@trop trop bot commented Nov 23, 2020

Backport of #26608

See that PR for details.

Notes: Fixed contentTracing.stopRecording() not rejecting when there is no trace in progress.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Nov 23, 2020
@trop trop bot requested a review from nornagon November 23, 2020 19:03
@trop trop bot mentioned this pull request Nov 23, 2020
Merged
4 tasks
@trop trop bot added 12-x-y backport This is a backport PR labels Nov 23, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Nov 23, 2020
@nornagon
Copy link
Contributor

CI failures unrelated.

@nornagon nornagon merged commit 1cac335 into 12-x-y Nov 23, 2020
@release-clerk
Copy link
release-clerk bot commented Nov 23, 2020

Release Notes Persisted

Fixed contentTracing.stopRecording() not rejecting when there is no trace in pro 8740 gress.

@trop trop bot deleted the trop/12-x-y-bp-fix-reject-contenttracing-stoprecording-on-failure-1606158225722 branch November 23, 2020 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@nornagon nornagon Awaiting requested review from nornagon

Assignees
No one assigned
Labels
12-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nornagon @codebytere
0