8000 fix: reject contentTracing.stopRecording on failure by nornagon · Pull Request #26608 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: reject contentTracing.stopRecording on failure #26608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 23, 2020
Merged

fix: reject contentTracing.stopRecording on failure #26608

merged 2 commits into from
Nov 23, 2020

Conversation

nornagon
Copy link
Contributor

Description of Change

Fixes #26607. I'm not sure this catches all situations in which the
FileEndpoint's callback isn't called, but it catches a major one!

Checklist

Release Notes

Notes: Fixed contentTracing.stopRecording() not rejecting when there is no trace in progress.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Nov 19, 2020
@codebytere
Copy link
Member

Interesting crash on this one:

Received signal 4 ILL_ILLOPN 00005fa795df
#0 0x00005cbcd33f base::debug::CollectStackTrace()
#1 0x00005cb09702 base::debug::StackTrace::StackTrace()
#2 0x00005cbccfbb base::debug::(anonymous namespace)::StackDumpSignalHandler()
#3 0x0000f7f0f0a0 ([vdso]+0x109f)
#4 0x00005fa795df v8::base::OS::Abort()
#5 0x00005fa72a1b V8_Fatal()
#6 0x00005fa72646 v8::base::(anonymous namespace)::DefaultDcheckHandler()
#7 0x00005fa72a43 V8_Dcheck()
#8 0x00005a1a19ce v8::Context::Enter()
#9 0x000058d970bd gin_helper::PromiseBase::RejectWithErrorMessage()
#10 0x000058c5a83d (anonymous namespace)::StopTracing()
#11 0x000058c5b4ae base::internal::Invoker<>::RunOnce()
#12 0x000058c5b0e9 base::internal::ReplyAdapter<>()
#13 0x000058c5b306 base::internal::Invoker<>::RunOnce()
#14 0x00005cbb06fd base::(anonymous namespace)::PostTaskAndReplyRelay::RunReply()
#15 0x00005cbb07bd base::internal::Invoker<>::RunOnce()
#16 0x00005cb6d78e base::TaskAnnotator::RunTask()
#17 0x00005cb8a6b2 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl()
#18 0x00005cb8a213 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork()
#19 0x00005cb8af74 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork()
#20 0x00005cb29ef5 base::MessagePumpGlib::Run()
#21 0x00005cb8b408 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run()
#22 0x00005cb8b5a6 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run()
#23 0x00005cb50552 base::RunLoop::Run()
#24 0x00005bbd6fff content::BrowserMainLoop::RunMainMessageLoopParts()
#25 0x00005bbd9a5d content::BrowserMainRunnerImpl::Run()
#26 0x00005bbd3402 content::BrowserMain()
#27 0x000059ffd2d2 content::ContentMainRunnerImpl::RunServiceManager()
#28 0x000059ffcd9f content::ContentMainRunnerImpl::Run()
#29 0x000059ffaa3d content::RunContentProcess()
#30 0x000059ffab4b content::ContentMain()
#31 0x000058c21e6a main
#32 0x0000f5f59e91 __libc_start_main
#33 0x000058c095b1 _start
  gs: 00000063  fs: 00000000  es: 0000002b  ds: 0000002b
 edi: ffb1476c esi: f6119e18 ebp: ffb14538 esp: ffb14530
 ebx: 61b38558 edx: 00000000 ecx: f611a884 eax: 00000000
 trp: 00000006 err: 00000000  ip: 5fa795df  cs: 00000023
 efl: 00210202 usp: ffb14530  ss: 0000002b

@nornagon
Copy link
Contributor Author

oh, crap, the promise was std::moved. sigh, okay

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Nov 20, 2020
@codebytere codebytere merged commit 854d2b1 into master Nov 23, 2020
@release-clerk
Copy link
release-clerk bot commented Nov 23, 2020

Release Notes Persisted

Fixed contentTracing.stopRecording() not rejecting when there is no trace in progress.

@codebytere codebytere deleted the content-tracing-stop-reject branch November 23, 2020 18:20
@nornagon
Copy link
Contributor Author

/trop run backport

@trop
Copy link
Contributor
trop bot commented Nov 23, 2020

The backport process for this PR has been manually initiated, here we go! :D

This was referenced Nov 23, 2020
Merged
Merged
@trop
Copy link
Contributor
trop bot commented Nov 23, 2020

I have automatically backported this PR to "11-x-y", please check out #26655

@trop
Copy link
Contributor
trop bot commented Nov 23, 2020

I have automatically backported this PR to "12-x-y", please check out #26656

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

contentTracing.stopRecording() never resolves if called when not recording
3 participants
@nornagon @codebytere @MarshallOfSound
0