10000 chore: update build_bring_back_node_with_ltcg_configuration.patch by deepak1556 · Pull Request #20672 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: update build_bring_back_node_with_ltcg_configuration.patch #20672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 23, 2019
Merged

chore: update build_bring_back_node_with_ltcg_configuration.patch #20672

merged 2 commits into from
Oct 23, 2019

Conversation

deepak1556
Copy link
Member
@deepak1556 deepak1556 commented Oct 21, 2019 •
edited
Loading

Description of Change

Follow up #20614

Set default value for node_with_ltcg=true, and moves the definition to Release configuration.

Thanks to @miniak for spotting the regression.

Checklist

Release Notes

Notes: fix native module size increase on windows, follow up fix to #20614

@deepak1556 deepak1556 requested review from nornagon and miniak October 21, 2019 22:35
@deepak1556 deepak1556 requested a review from a team as a code owner October 21, 2019 22:35
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Oct 21, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Oct 22, 2019
@deepak1556 deepak1556 requested a review from a team October 23, 2019 00:53
@deepak1556 deepak1556 merged commit 6dc101f into master Oct 23, 2019
@release-clerk
Copy link
release-clerk bot commented Oct 23, 2019

Release Notes Persisted

fix native module size increase on windows, follow up fix to #20614

This was referenced Oct 23, 2019
Merged
Merged
@trop
Copy link
Contributor
trop bot commented Oct 23, 2019

I have automatically backported this PR to "5-0-x", please check out #20707

@trop trop bot mentioned this pull request Oct 23, 2019
Merged
@trop trop bot removed the target/5-0-x label Oct 23, 2019
@trop
Copy link
Contributor
trop bot commented Oct 23, 2019

I have automatically backported this PR to "7-0-x", please check out #20708

@trop trop bot added the in-flight/5-0-x label Oct 23, 2019
@trop
Copy link
Contributor
trop bot commented Oct 23, 2019

I have automatically backported this PR to "6-1-x", please check out #20709

@deepak1556 deepak1556 deleted the robo/fix_ltcg_2 branch October 23, 2019 19:49
@trop trop bot removed the in-flight/6-1-x label Oct 23, 2019
@deepak1556
Copy link
Member Author

/trop run backport-to 8-x-y

@trop
Copy link
Contributor
trop bot commented Jan 28, 2020

The backport process for this PR has been manually initiated -
sending your commits to "8-x-y"!

@trop trop bot mentioned this pull request Jan 28, 2020
Merged
@trop
Copy link
Contributor
trop bot commented Jan 28, 2020

I have automatically backported this PR to "8-x-y", please check out #21947

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@miniak miniak miniak approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deepak1556 @nornagon @miniak @MarshallOfSound
0