8000 fix: add patch to node for native module size issue on windows by deepak1556 · Pull Request #20614 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: add patch to node for native module size issue on windows #20614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2019
Merged

fix: add patch to node for native module size issue on windows #20614

merged 1 commit into from
Oct 17, 2019

Conversation

deepak1556
Copy link
Member
@deepak1556 deepak1556 commented Oct 16, 2019 •
edited
Loading

Description of Change

Fixes #18670

As part of https://github.com/nodejs/node/pull/25931 node_with_ltcg configuration was moved to
node.gyp which caused native modules size increase which were depending on
this configuration transitively https://github.com/nodejs/node/issues/29501 through common.gypi.

On a longer term to prevent these kinds of issue, nodejs/node-gyp#1118 should be addressed and will take sometime for me to address it. Landing this as a temporary patch.

Checklist

Release Notes

Notes: fix native modules size increase with VC++ and node 12 on windows

@deepak1556 deepak1556 requested review from miniak and a team October 16, 2019 20:59
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Oct 16, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Oct 17, 2019
@jkleinsc jkleinsc merged commit 58115c1 into master Oct 17, 2019
@release-clerk
Copy link
release-clerk bot commented Oct 17, 2019

Release Notes Persisted

fix native modules size increase with VC++ and node 12 on windows

@trop
Copy link
Contributor
trop bot commented Oct 17, 2019

I was unable to backport this PR to "6-0-x" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/6-0-x label Oct 17, 2019
@trop
Copy link
Contributor
trop bot commented Oct 17, 2019

I was unable to backport this PR to "5-0-x" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor
trop bot commented Oct 17, 2019

I was unable to backport this PR to "7-0-x" cleanly;
you will need to perform this backport manually.

@deepak1556 deepak1556 deleted the robo/fix_nm_size branch October 17, 2019 21:22
@deepak1556
Copy link
Member Author

Will create manual backports by EOD.

deepak1556 added a commit that referenced this pull request Oct 18, 2019
@deepak1556
fix: add patch to node for native module size issue on windows (#20614)
9178a1b
deepak1556 added a commit that referenced this pull request Oct 18, 2019
@deepak1556
fix: add patch to node for native module size issue on windows (#20614)
f42316d
deepak1556 added a commit that referenced this pull request Oct 18, 2019
@deepak1556
fix: add patch to node for native module size issue on windows (#20614)
20b8b4c
@deepak1556 deepak1556 mentioned this pull request Oct 18, 2019
Merged
6 tasks
@trop
Copy link
Contributor
trop bot commented Oct 18, 2019

@deepak1556 has manually backported this PR to "7-0-x", please check out #20626

@trop trop bot added the in-flight/7-0-x label Oct 18, 2019
@deepak1556 deepak1556 mentioned this pull request Oct 18, 2019
Merged
6 tasks
@trop
Copy link
Contributor
trop bot commented Oct 18, 2019

@deepak1556 has manually backported this PR to "6-0-x", please check out #20627

@deepak1556 deepak1556 mentioned this pull request Oct 18, 2019
Merged
6 tasks
@trop
Copy link
Contributor
trop bot commented Oct 18, 2019

@deepak1556 has manually backported this PR to "5-0-x", please check out #20628

jkleinsc pushed a commit that referenced this pull request Oct 18, 2019
@deepak1556
fix: add patch to node for native module size issue on windows (#20614)…
d5b088b 
… (#20627)
codebytere pushed a commit that referenced this pull request Oct 18, 2019
@deepak1556 @codebytere
fix: add patch to node for native module size issue on windows (#20614)…
eda12de 
… (#20628)
codebytere pushed a commit that referenced this pull request Oct 18, 2019
@deepak1556 @codebytere
fix: add patch to node for native module size issue on windows (#20614)…
2a2f7e7 
… (#20626)
@deepak1556 deepak1556 mentioned this pull request Oct 21, 2019
Merged
6 tasks
This was referenced Oct 23, 2019
Merged
Merged
Merged
@gpetrov gpetrov mentioned this pull request Nov 10, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Nov 14, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Nov 30, 2019
Open
@trop trop bot mentioned this pull request Jan 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

@codebytere codebytere codebytere approved these changes

@miniak miniak Awaiting requested review from miniak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Native node modules binaries targeting Electron 4+ are bloated
4 participants
@deepak1556 @nornagon @jkleinsc @codebytere
0