8000 fix: refactoring regression in LocationProxy by miniak · Pull Request #19494 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: refactoring regression in LocationProxy #19494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2019
Merged

fix: refactoring regression in LocationProxy #19494

merged 1 commit into from
Jul 29, 2019

Conversation

miniak
Copy link
Contributor
@miniak miniak commented Jul 28, 2019 •
edited
Loading

Description of Change

Fixes regression introduced in #17591
Screen Shot 2019-07-28 at 11 51 48 AM

Checklist

Release Notes

Notes: Fixed popup.location.* setters when nativeWindowOpen is disabled.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jul 28, 2019
8000
@miniak miniak self-assigned this Jul 28, 2019
@miniak miniak added the 6-0-x label Jul 28, 2019
@miniak miniak force-pushed the miniak/fix-location-proxy-6-0-x branch from 9e6ca36 to b656201 Compare July 28, 2019 10:01
@miniak miniak marked this pull request as ready for review July 28, 2019 10:02
@miniak miniak force-pushed the miniak/fix-location-proxy-6-0-x branch from b656201 to a2531f6 Compare July 28, 2019 10:09
@miniak miniak requested a review from MarshallOfSound July 28, 2019 10:14
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jul 29, 2019
@codebytere codebytere merged commit 922a4d9 into 6-0-x Jul 29, 2019
@release-clerk
Copy link
release-clerk bot commented Jul 29, 2019

Release Notes Persisted

Fixed popup.location.* setters when nativeWindowOpen is disabled.

@codebytere codebytere deleted the miniak/fix-location-proxy-6-0-x branch July 29, 2019 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeykuzmin alexeykuzmin alexeykuzmin approved these changes

@zcbenz zcbenz zcbenz approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees

@miniak miniak

Labels
6-0-x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miniak @alexeykuzmin @zcbenz @MarshallOfSound @codebytere
0