8000 refactor: expose ipcRendererInternal to the main world for window-setup using the content script world pattern by miniak · Pull Request #17591 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: expose ipcRendererInternal to the main world for window-setup using the content script world pattern #17591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2019
Merged

refactor: expose ipcRendererInternal to the main world for window-setup using the content script world pattern #17591

merged 1 commit into from
Mar 30, 2019

Conversation

miniak
Copy link
Contributor
@miniak miniak commented Mar 28, 2019 •
edited
Loading

Description of Change

This allows using the ipc-renderer-internal-utils module easily, without having to pass it from the outside as well. Inspired by #17032 (which got fixed in #17422)

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: no-notes

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Mar 28, 2019
@miniak miniak marked this pull request as ready for review March 28, 2019 18:18
MarshallOfSound
MarshallOfSound approved these changes Mar 28, 2019
View reviewed changes
Copy link
Member
@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit but I'd like another set of eyes on it

@miniak miniak self-assigned this Mar 28, 2019
@miniak
Copy link
Contributor Author
miniak commented Mar 29, 2019 •
edited
Loading

@zcbenz, @deepak1556 can you please review?

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Mar 29, 2019
@MarshallOfSound MarshallOfSound merged commit d597a0e into master Mar 30, 2019
@release-clerk
Copy link
release-clerk bot commented Mar 30, 2019

No Release Notes

@MarshallOfSound MarshallOfSound deleted the miniak/window-setup branch March 30, 2019 01:10
kiku-jw pushed a commit to kiku-jw/electron that referenced this pull request May 16, 2019
@miniak @kiku-jw
refactor: expose ipcRendererInternal to the main world for window-set…
47dec18 
…up using the content script world pattern (electron#17591)
@miniak
Copy link
Contributor Author
miniak commented Jul 28, 2019

/trop run backport-to 6-0-x

@trop
Copy link
Contributor
trop bot commented Jul 28, 2019

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "6-0-x" here we go! :D

@trop
Copy link
Contributor
trop bot commented Jul 28, 2019

I was unable to backport this PR to "6-0-x" cleanly;
you will need to perform this backport manually.

@miniak miniak mentioned this pull request Jul 28, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@samuelmaddock samuelmaddock samuelmaddock approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@nornagon nornagon Awaiting requested review from nornagon

Assignees

@miniak miniak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miniak @zcbenz @samuelmaddock @MarshallOfSound
0