8000 fix: pass the correct HostPort into the node inspector by MarshallOfSound · Pull Request #17380 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: pass the correct HostPort into the node inspector #17380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2019
Merged

fix: pass the correct HostPort into the node inspector #17380

merged 1 commit into from
Mar 18, 2019

Conversation

MarshallOfSound
Copy link
Member

Fixes #17348

Description of Change

We were passing the incorrect HostPort instance into the inspector start call. This passes the correct one in.

Release Notes

Notes: launching the node inspector through --inspect now listens on the correct port when one is provided

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Mar 14, 2019
@MarshallOfSound MarshallOfSound added target/5-0-x and removed new-pr 🌱 PR opened recently labels Mar 14, 2019
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Mar 14, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Mar 15, 2019
@MarshallOfSound MarshallOfSound merged commit 5025c99 into master Mar 18, 2019
@release-clerk
Copy link
release-clerk bot commented Mar 18, 2019

Release Notes Persisted

launching the node inspector through --inspect now listens on the correct port when one is provided

@trop
Copy link
Contributor
trop bot commented Mar 18, 2019

I have automatically backported this PR to "5-0-x", please check out #17439

@trop trop bot mentioned this pull request Mar 18, 2019
Merged
kiku-jw pushed a commit to kiku-jw/electron that referenced this pull request May 16, 2019
@MarshallOfSound @kiku-jw
fix: pass the correct HostPort into the node inspector (electron#17380)
5fc6477 
Fixes electron#17348
@codebytere codebytere deleted the fix-inspect branch August 6, 2019 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarshallOfSound @deepak1556
0