8000 fix: pass the correct HostPort into the node inspector (backport: 5-0-x) by trop[bot] · Pull Request #17439 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: pass the correct HostPort into the node inspector (backport: 5-0-x) #17439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2019
Merged

fix: pass the correct HostPort into the node inspector (backport: 5-0-x) #17439

merged 1 commit into from
Mar 18, 2019

Conversation

trop[bot]
Copy link
Contributor
@trop trop bot commented Mar 18, 2019

Backport of #17380

See that PR for details.

Notes: launching the node inspector through --inspect now listens on the correct port when one is provided

@trop trop bot mentioned this pull request Mar 18, 2019
Merged
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Mar 18, 2019
@trop trop bot added 5-0-x backport This is a backport PR labels Mar 18, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Mar 18, 2019
@codebytere codebytere merged commit 5b34f9b into electron:5-0-x Mar 18, 2019
@release-clerk
Copy link
release-clerk bot commented Mar 18, 2019

Release Notes Persisted

launching the node inspector through --inspect now listens on the correct port when one is provided

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
5-0-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codebytere @MarshallOfSound
0