8000 refactor: make name a prop on app by codebytere · Pull Request #17701 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: make name a prop on app #17701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 30, 2019
Merged

refactor: make name a prop on app #17701

merged 4 commits into from
Apr 30, 2019

Conversation

codebytere
Copy link
Member
@codebytere codebytere commented Apr 5, 2019 •
edited
Loading

Description of Change

Update app.name to be a property on app.

Checklist

Release Notes

Notes: Updated name to be a property on the app module.

@electron-cation electron-cation bot added new-pr 🌱 PR opened recently and removed new-pr 🌱 PR opened recently labels Apr 5, 2019
@codebytere codebytere marked this pull request as ready for review April 19, 2019 20:18
@codebytere codebytere added semver/minor backwards-compatible functionality target/6-0-x labels Apr 19, 2019
MarshallOfSound
MarshallOfSound reviewed Apr 29, 2019
View reviewed changes
@codebytere
Copy link
Member Author

Still some win failures i'm sussing out 👇

@codebytere codebytere merged commit 8d83518 into master Apr 30, 2019
@release-clerk
Copy link
release-clerk bot commented Apr 30, 2019

Release Notes Persisted

Updated name to be a property on the app module.

@codebytere codebytere deleted the app-name-prop branch April 30, 2019 20:55
@electron electron deleted a comment from trop bot Apr 30, 2019
kiku-jw pushed a commit to kiku-jw/electron that referenced this pull request May 16, 2019
@codebytere @kiku-jw
refactor: make name a prop on app (electron#17701)
5215db1 
Update app.name to be a property on app.
@erickzhao erickzhao mentioned this pull request Mar 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miniak miniak miniak approved these changes

@nornagon nornagon Awaiting requested review from nornagon

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees
No one assigned
Labels
semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codebytere @miniak @MarshallOfSound
0