8000 update `app.getName()` -> `app.name` by erickzhao · Pull Request #47 · catdad/electronmon · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

update app.getName() -> app.name #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 3, 2020
Merged

update app.getName() -> app.name #47

merged 3 commits into from
Mar 3, 2020

Conversation

erickzhao
Copy link
Contributor

Closes #34.

The app.getName() API and its counterpart app.setName() were deprecated some time ago.

catdad
catdad reviewed Mar 3, 2020
View reviewed changes
@erickzhao erickzhao requested a review from catdad March 3, 2020 23:35
@erickzhao
Copy link
Contributor Author
erickzhao commented Mar 3, 2020 •
edited
Loading

Seems like CI failed after my last change so I'll to check out the repo

Derp, serves me right for not checking out the repo 🤦‍♂

const { app } = electron.app;

@catdad
Copy link
Owner
catdad commented Mar 3, 2020

Haha, we've all been there. Thanks for the update, I'll publish this in a few minutes

@catdad catdad merged commit 31a6af9 into catdad:master Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catdad catdad Awaiting requested review from catdad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'getName function' is deprecated and will be removed
2 participants
@erickzhao @catdad
0