8000 docs: document the Event interface by codebytere · Pull Request #16966 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: document the Event interface #16966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 15, 2019
Merged

docs: document the Event interface #16966

merged 3 commits into from
Feb 15, 2019

Conversation

codebytere
Copy link
Member
@codebytere codebytere commented Feb 14, 2019 •
edited
Loading

Description of Change

Document the Event interface in coordination with electron/typescript-definitions#131.

cc @MarshallOfSound

Checklist

Release Notes

Notes: Documented the Event interface as an API structure.

@codebytere codebytere requested a review from a team February 14, 2019 16:14
@codebytere codebytere force-pushed the add-event-structure branch 2 times, most recently from ae1570c to 9f1f45b Compare February 14, 2019 16:43
@MarshallOfSound
Copy link
Member

I'm not quite sure how to make it extend GlobalEvent

This would require updates to docs-linter and typescript-definitions to understand "extends"

@codebytere codebytere changed the title docs: document the Event interface [wip] docs: document the Event interface Feb 14, 2019
@codebytere codebytere requested a review from a team February 14, 2019 22:12
@codebytere codebytere changed the title [wip] docs: document the Event interface docs: document the Event interface Feb 15, 2019
@codebytere codebytere mentioned this pull request Feb 15, 2019
Merged
4 tasks
@codebytere codebytere merged commit 1e8ac79 into master Feb 15, 2019
@release-clerk
Copy link
release-clerk bot commented Feb 15, 2019

Release Notes Persisted

Documented the Event interface as an API structure.

@codebytere codebytere deleted the add-event-structure branch February 15, 2019 20:08
@trop
Copy link
Contributor
trop bot commented Feb 15, 2019
ABC0

I was unable to backport this PR to "4-0-x" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/4-0-x label Feb 15, 2019
@trop
Copy link
Contributor
trop bot commented Feb 15, 2019

I was unable to backport this PR to "5-0-x" cleanly;
you will need to perform this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codebytere @MarshallOfSound
0