8000 feat: show user gesture type in click event by codebytere · Pull Request #16954 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: show user gesture type in click event #16954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2019
Merged

feat: show user gesture type in click event #16954

merged 1 commit into from
Feb 20, 2019

Conversation

codebytere
Copy link
Member
@codebytere codebytere commented Feb 14, 2019 •
edited
Loading

Description of Change

Resolves: #16947

Adds a new Event property triggeredByAccelerator, which is called back in custom click events on MenuItems.

cc @MarshallOfSound

Checklist

Release Notes

Notes: Added a new Event property triggeredByAccelerator, which is called back in custom click events on MenuItems.

@codebytere codebytere requested a review from a team February 14, 2019 03:45
This was referenced Feb 14, 2019
Merged
Closed
jkleinsc
jkleinsc reviewed Feb 14, 2019
View reviewed changes
Copy link
Member
@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a doc change for this?

@codebytere
Copy link
Member Author
codebytere commented Feb 15, 2019 •
edited
Loading

@jkleinsc this is part of a messy jigsaw puzzle happening in the past few days! This PR is pending merge of #16966, at which time that new structure declaration will be updated to reflect this new Event property :)

@codebytere codebytere added semver/minor backwards-compatible functionality blocked labels Feb 15, 2019
@codebytere codebytere requested a review from a team February 15, 2019 20:09
@codebytere codebytere merged commit 3edc497 into master Feb 20, 2019
@release-clerk
Copy link
release-clerk bot commented Feb 20, 2019

Release Notes Persisted

Added a new Event property triggeredByAccelerator, which is called back in custom click events on MenuItems.

@codebytere codebytere deleted the show-trigger-type branch February 20, 2019 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codebytere @jkleinsc
0