10000 refactor: don't expose NavigationController as an internal module by miniak · Pull Request #15920 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: don't expose NavigationController as an internal module #15920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2018
Merged

refactor: don't expose NavigationController as an internal module #15920

merged 1 commit into from
Dec 3, 2018

Conversation

miniak
Copy link
Contributor
@miniak miniak commented Dec 2, 2018
Description of Change

There is no reason to treat NavigationController as a module. It's leaking implementation details as you can access it in apps via electron.NavigationController. Related to #14389.

Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines
Release Notes

Notes: no-notes

deepak1556
deepak1556 approved these changes Dec 2, 2018
View reviewed changes
Copy link
Member
@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please fix the filename in build config. Thanks!

@miniak miniak force-pushed the miniak/navigation-controller branch from f6a70b1 to b638538 Compare December 2, 2018 21:47
@miniak
Copy link
Contributor Author
miniak commented Dec 2, 2018

@deepak1556 fixed

codebytere
codebytere approved these changes Dec 3, 2018
View reviewed changes
Copy link
Member
@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexeykuzmin alexeykuzmin merged commit a33eeda into master Dec 3, 2018
@release-clerk
Copy link
release-clerk bot commented Dec 3, 2018

No Release Notes

@alexeykuzmin alexeykuzmin deleted the miniak/navigation-controller branch December 3, 2018 16:13
@miniak miniak mentioned this pull request Aug 11, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeykuzmin alexeykuzmin alexeykuzmin approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

@codebytere codebytere codebytere approved these changes

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miniak @alexeykuzmin @deepak1556 @codebytere
0