8000 refactor: don't expose CallbacksRegistry as an internal module by miniak · Pull Request #14389 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: don't expose CallbacksRegistry as an internal module #14389

New issue 8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2018
Merged

refactor: don't expose CallbacksRegistry as an internal module #14389

merged 1 commit into from
Aug 31, 2018

Conversation

miniak
Copy link
Contributor
@miniak miniak commented Aug 30, 2018 •
edited
Loading
Description of Change

There is no reason to treat CallbacksRegistry as a module. The related ObjectsRegistry is not treated as a module either. It's leaking implementation details as you can access it in apps via electron.CallbacksRegistry.

Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines
Release Notes

Notes: no-notes

deepak1556
deepak1556 reviewed Aug 30, 2018
View reviewed changes
Copy link
Member
@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

  • while you are at this, I think we can move callback-registry.js into renderer, since its specific to it.

  • Need to fix the require call in api-callbacks-registry-spec.js

@miniak
Copy link
Contributor Author
miniak commented Aug 30, 2018

@deepak1556 will do that

@miniak miniak force-pushed the miniak/callbacks-registry branch from 2ae6d88 to 5ffb96a Compare August 30, 2018 20:51
@miniak miniak force-pushed the miniak/callbacks-registry branch from 5ffb96a to 6c45671 Compare August 30, 2018 20:54
@miniak
Copy link
Contributor Author
miniak commented Aug 30, 2018

@deepak1556 both comments resolved

@miniak
Copy link
Contributor Author
miniak commented Aug 31, 2018

@ckerr, @codebytere can you please merge?

@codebytere codebytere merged commit 3a79eac into master Aug 31, 2018
@release-clerk
Copy link
8000 release-clerk bot commented Aug 31, 2018

No Release Notes

@alexeykuzmin alexeykuzmin deleted the miniak/callbacks-registry branch August 31, 2018 18:40
@miniak miniak mentioned this pull request Dec 2, 2018
Merged
3 tasks
@ckerr ckerr mentioned this pull request Dec 18, 2018
Closed
@miniak miniak mentioned this pull request Jul 7, 2019
Merged
3 tasks
@miniak miniak mentioned this pull request Aug 11, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeykuzmin alexeykuzmin alexeykuzmin approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

@codebytere codebytere codebytere approved these changes

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

@ckerr ckerr Awaiting requested review from ckerr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miniak @alexeykuzmin @deepak1556 @codebytere
0