fix: crash in sandbox on linux when getting execPath #15701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calling base::PathService::Get(base::FILE_EXE, &path) on linux crashes in sandbox.
miniak
approved these changes
8000
Nov 14, 2018
|
@nornagon, I don’t remember exactly, I should probably just have used |
deepak1556
approved these changes
Nov 14, 2018
|
I'm also still uncertain about removing |
|
@nornagon |
|
Merging this without review from @electron/docs because the change to docs is trivial. I'm removing |
|
Release Notes Persisted
|
simonecattaneo91
pushed a commit
to simonecattaneo91/electron
that referenced
this pull request
Nov 16, 2018
simonecattaneo91
pushed a commit
to simonecattaneo91/electron
that referenced
this pull request
Nov 16, 2018
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
calling
base::PathService::Get(base::FILE_EXE, &path)on linux crashes with--enable-sandbox:Checklist
npm testpassesRelease Notes
Notes:
resourcesPathproperty is no longer available onprocessin sandboxed renderers