8000 fix: process.execPath returning parent process path instead of the helper in sandboxed renderer by miniak · Pull Request #13839 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: process.execPath returning parent process path instead of the helper in sandboxed renderer #13839

New issue 8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2018
Merged

fix: process.execPath returning parent process path instead of the helper in sandboxed renderer #13839

merged 1 commit into from
Jul 30, 2018

Conversation

miniak
Copy link
Contributor
@miniak miniak commented Jul 28, 2018 •
edited
Loading

Before the fix the process.execPath value is sent by the main process, which has a different executable on Mac (Electron vs Electron Helper). It needs to be determined on the renderer process side.

Checklist

@miniak miniak requested a review from a team July 28, 2018 14:43
@miniak miniak requested a review from tarruda July 28, 2018 14:45
@miniak
Copy link
Contributor Author
miniak commented Jul 28, 2018

@tarruda can you please review?

@miniak miniak mentioned this pull request Jul 28, 2018
Merged
5 tasks
@miniak miniak force-pushed the miniak/fix-process-execpath branch from 041dfe2 to bc96a79 Compare July 28, 2018 14:55
@miniak miniak force-pushed the miniak/fix-process-execpath branch from bc96a79 to 2520a9e Compare July 29, 2018 14:14
@miniak miniak requested a review from a team July 29, 2018 14:14
@MarshallOfSound MarshallOfSound merged commit db38c8b into master Jul 30, 2018
@MarshallOfSound MarshallOfSound deleted the miniak/fix-process-execpath branch July 30, 2018 01:13
@trop
Copy link
Contributor
trop bot commented Jul 30, 2018

An error occurred while attempting to backport this PR to "3-0-x", you will need to perform this backport manually

@alexeykuzmin
Copy link
Contributor

An error occurred while attempting to backport this PR to "3-0-x", you will need to perform this backport manually

@miniak Can you please create a backport?

@miniak miniak mentioned this pull request Aug 6, 2018
Merged
4 tasks
@miniak
Copy link
Contributor Author
miniak commented Aug 6, 2018

@alexeykuzmin done

@nornagon nornagon mentioned this pull request Nov 13, 2018
Merged
5 tasks
@ckerr ckerr mentioned this pull request Dec 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarruda tarruda tarruda approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miniak @alexeykuzmin @tarruda @MarshallOfSound
2917
0