feat: allow setting window shape (#13789) (backport 2-1-x) #13989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a2090c1 to
4c3d310
Compare
ckerr
requested changes
Aug 8, 2018
4f73dae to
055ab61
Compare
This binds Widget::SetShape, an API that already exists in Chromium (for Windows and Linux). It's a more reliable method of having some parts of your window be "click-through" than the current `setIgnoreMouseEvents` API, which messes around with the `WS_EX_LAYERED` window style on Windows, causing strange bugs and incompatibility with hardware acceleration.
055ab61 to
d74e25f
Compare
ckerr
requested changes
Aug 8, 2018
| auto native_window_views = static_cast<NativeWindowViews*>(window_.get()); | ||
| auto shape = base::MakeUnique<SkRegion>(); | ||
| for (const auto& rect : rects) | ||
| shape->op(gfx::RectToSkIRect(rect), SkRegion::kUnion_Op); |
There was a problem hiding this comment.
The SkRegion::setRects() documentation suggests it be used instead of the above:
/**
* Set this region to the union of an array of rects. This is generally
* faster than calling region.op(rect, kUnion_Op) in a loop. If count is
* 0, then this region is set to the empty region.
* @return true if the resulting region is non-empty
*/
bool setRects(const SkIRect rects[], int count);There was a problem hiding this comment.
Huh! I copied this code from the DesktopWindowTreeHostX11::SetShape code.
ckerr
approved these changes
Aug 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This binds Widget::SetShape, an API that already exists in Chromium (for
Windows and Linux). It's a more reliable method of having some parts of
your window be "click-through" than the current
setIgnoreMouseEventsAPI, which messes around with the
WS_EX_LAYEREDwindow style onWindows, causing strange bugs and incompatibility with hardware
acceleration.