feat: allow setting window shape #13789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51aef5a to
c688a92
Compare
This binds Widget::SetShape, an API that already exists in Chromium (for Windows and Linux). It's a more reliable method of having some parts of your window be "click-through" than the current `setIgnoreMouseEvents` API, which messes around with the `WS_EX_LAYERED` window style on Windows, causing strange bugs and incompatibility with hardware acceleration.
c688a92 to
41a322e
Compare
codebytere
approved these changes
Jul 26, 2018
zeke
reviewed
Jul 26, 2018
| @@ -1262,6 +1262,11 @@ Sets the opacity of the window. On Linux does nothing. | |||
|
|
|||
| Returns `Number` - between 0.0 (fully transparent) and 1.0 (fully opaque) | |||
|
|
|||
| #### `win.setShape(rects)` _Windows_ _Linux_ _Experimental_ | |||
|
|
|||
| * `rects` [Rectangle[]](structures/rectangle.md) - Sets a shape on the window. | |||
There was a problem hiding this comment.
Can you expand this documentation a bit to explain what shapes are and why you'd want to use them?
|
/trop run backport-to 2-1-x |
|
The backport process for this PR has been manually initiated, sending your 1's and 0's to "2-1-x" here we go! :D |
ckerr
pushed a commit
that referenced
this pull request
Aug 8, 2018
This binds Widget::SetShape, an API that already exists in Chromium (for Windows and Linux). It's a more reliable method of having some parts of your window be "click-through" than the current `setIgnoreMouseEvents` API, which messes around with the `WS_EX_LAYERED` window style on Windows, causing strange bugs and incompatibility with hardware acceleration.
nornagon
added a commit
that referenced
this pull request
Aug 8, 2018
This binds Widget::SetShape, an API that already exists in Chromium (for Windows and Linux). It's a more reliable method of having some parts of your window be "click-through" than the current `setIgnoreMouseEvents` API, which messes around with the `WS_EX_LAYERED` window style on Windows, causing strange bugs and incompatibility with hardware acceleration.
nornagon
added a commit
that referenced
this pull request
Aug 8, 2018
This binds Widget::SetShape, an API that already exists in Chromium (for Windows and Linux). It's a more reliable method of having some parts of your window be "click-through" than the current `setIgnoreMouseEvents` API, which messes around with the `WS_EX_LAYERED` window style on Windows, causing strange bugs and incompatibility with hardware acceleration.
nornagon
added a commit
that referenced
this pull request
Aug 8, 2018
This binds Widget::SetShape, an API that already exists in Chromium (for Windows and Linux). It's a more reliable method of having some parts of your window be "click-through" than the current `setIgnor 8000 eMouseEvents` API, which messes around with the `WS_EX_LAYERED` window style on Windows, causing strange bugs and incompatibility with hardware acceleration.
nornagon
added a commit
that referenced
this pull request
Aug 8, 2018
This binds Widget::SetShape, an API that already exists in Chromium (for Windows and Linux). It's a more reliable method of having some parts of your window be "click-through" than the current `setIgnoreMouseEvents` API, which messes around with the `WS_EX_LAYERED` window style on Windows, causing strange bugs and incompatibility with hardware acceleration.
nornagon
added a commit
that referenced
this pull request
Aug 8, 2018
This binds Widget::SetShape, an API that already exists in Chromium (for Windows and Linux). It's a more reliable method of having some parts of your window be "click-through" than the current `setIgnoreMouseEvents` API, which messes around with the `WS_EX_LAYERED` window style on Windows, causing strange bugs and incompatibility with hardware acceleration.
nornagon
added a commit
that referenced
this pull request
Aug 8, 2018
This binds Widget::SetShape, an API that already exists in Chromium (for Windows and Linux). It's a more reliable method of having some parts of your window be "click-through" than the current `setIgnoreMouseEvents` API, which messes around with the `WS_EX_LAYERED` window style on Windows, causing strange bugs and incompatibility with hardware acceleration.
ckerr
pushed a commit
that referenced
this pull request
Aug 9, 2018
This binds Widget::SetShape, an API that already exists in Chromium (for Windows and Linux). It's a more reliable method of having some parts of your window be "click-through" than the current `setIgnoreMouseEvents` API, which messes around with the `WS_EX_LAYERED` window style on Windows, causing strange bugs and incompatibility with hardware acceleration.
felixrieseberg
pushed a commit
that referenced
this pull request
Aug 29, 2018
This binds Widget::SetShape, an API that already exists in Chromium (for Windows and Linux). It's a more reliable method of having some parts of your window be "click-through" than the current `setIgnoreMouseEvents` API, which messes around with the `WS_EX_LAYERED` window style on Windows, causing strange bugs and incompatibility with hardware acceleration.
5 tasks
|
/trop run backport-to 3-0-x |
|
The backport process for this PR has been manually initiated, |
|
We have automatically backported this PR to "3-0-x", please check out #14445 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This binds Widget::SetShape, an API that already exists in Chromium. It's a more reliable method of having some parts of your window be "click-through" than the current
setIgnoreMouseEventsAPI, which messes around with theWS_EX_LAYEREDwindow style, causing strange bugs and incompatibility with hardware acceleration.Checklist
npm testpasses