8000 Replace is/setFullscreen with is/setFullScreen · Issue #19 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Replace is/setFullscreen with is/setFullScreen #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kevinsawicki opened this issue Jun 7, 2013 · 0 comments
Closed

Replace is/setFullscreen with is/setFullScreen #19

kevinsawicki opened this issue Jun 7, 2013 · 0 comments

Comments

@kevinsawicki
Copy link
Contributor

Seems like the OS X APIs usually capitalize the S in Screen and the atom.coffee method is toggleFullScreen() currently.
@zcbenz zcbenz closed this as completed in 024c316 Jun 7, 2013
@ladenberger ladenberger mentioned this issue Jan 15, 2016
Closed
@antelle antelle mentioned this issue Apr 14, 2016
Closed
@tejohnso tejohnso mentioned this issue Jun 13, 2016
Closed
@ns ns mentioned this issue Feb 6, 2017
Closed
kevinsawicki pushed a commit that referenced this issue May 9, 2017
@aroben
Merge pull request #19 from brightray/file-protocol-handler
e84d11f 
Set file and data protocol handler.
kevinsawicki pushed a commit that referenced this issue May 9, 2017
@aroben
Update libchromiumcontent to be based on Chrome 28
b542fb3 
* vendor/libchromiumcontent f4f8a7e...929f9c9 (3):
  > Merge pull request #19 from brightray/chrome-28
  > Merge pull request #18 from brightray/encryptor
  > Merge pull request #17 from brightray/cygwin
kevinsawicki pushed a commit that referenced this issue May 9, 2017
@aroben
Merge pull request #19 from brightray/file-protocol-handler
14edfc7 
Set file and data protocol handler.
kevinsawicki pushed a commit that referenced this issue May 9, 2017
@aroben
Update libchromiumcontent to be based on Chrome 28
b17e63d 
* vendor/libchromiumcontent f4f8a7e...929f9c9 (3):
  > Merge pull request #19 from brightray/chrome-28
  > Merge pull request #18 from brightray/encryptor
  > Merge pull request #17 from brightray/cygwin
@avengerweb avengerweb mentioned this issue Oct 13, 2017
Closed
@ClarkWang-2013 ClarkWang-2013 mentioned this issue Nov 23, 2017
Merged
MarshallOfSound pushed a commit that referenced this issue May 1, 2018
@zcbenz
Merge pull request #19 from electron/get-wrapper-const
99d9e26 
GetWrapper should be const
@ckerr ckerr mentioned this issue Oct 24, 2018
Closed
@ppontes ppontes mentioned this issue Apr 23, 2021
Merged
@chust0788 chust0788 mentioned this issue Apr 28, 2022
Closed
3 tasks
This was referenced Jul 11, 2022
Merged
Merged
@wujinli wujinli mentioned this issue Jan 31, 2024
Merged
5 tasks
akaday referenced this issue in akaday/electron Nov 4, 2024
@akaday
Merge pull request #19 from akaday/main
d6bfc6a 
add
akaday referenced this issue in akaday/electron Nov 4, 2024
@akaday
Fix fullscreen methods to capitalize 'S' in 'Screen'
d820893 
Fixes #19

Update method names to use consistent capitalization for "FullScreen".

* Change `isFullscreen` to `isFullScreen` in `lib/browser/api/base-window.ts`.
* Change `setFullscreen` to `setFullScreen` in `lib/browser/api/base-window.ts`.
* Change `IsFullscreen` to `IsFullScreen` in `shell/browser/api/electron_api_base_window.cc`.
* Change `SetFullScreen` to `SetFullScreen` in `shell/browser/api/electron_api_base_window.cc`.
* Change `IsFullscreen` to `IsFullScreen` in `shell/browser/api/electron_api_base_window.h`.
* Change `SetFullScreen` to `SetFullScreen` in `shell/browser/api/electron_api_base_window.h`.
* Change `isFullScreen` to `isFullScreen` in `spec/api-power-monitor-spec.ts`.
* Change `setFullScreen` to `setFullScreen` in `spec/api-notification-spec.ts`.
* Change `isFullScreen` to `isFullScreen` in `spec/api-screen-spec.ts`.
* Change `setFullScreen` to `setFullScreen` in `spec/api-power-save-blocker-spec.ts`.
* Change `isFullScreen` to `isFullScreen` in `spec/api-net-spec.ts`.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/electron/electron/issues/19?shareId=XXXX-XXXX-XXXX-XXXX).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kevinsawicki
0