8000 fix compose index error by pca006132 · Pull Request #430 · elalish/manifold · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix compose index error #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. W 8000 e’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 12, 2023
Merged

fix compose index error #430

merged 2 commits into from
May 12, 2023

Conversation

pca006132
Copy link
Collaborator

Fixes #425 (comment)
Also, for #429, it seems that the error is now:

Triangulation failed! Precision = 0.000444848
Error in file: /home/pca006132/code/manifold/src/polygon/src/polygon.cpp (39): 'condition' is false: Not Geometrically Valid! None of the skipped verts is valid.
polys.push_back({
    {27.2981834, -7.01095772},  //
    {27.4199429, -7.07648039},  //
    {27.2981834, -7.01095724},  //
    {27.7852192, -7.27304506},  //
    {27.5622101, -6.52031708},  //
});
array([
  [27.2981834, -7.01095772],
  [27.4199429, -7.07648039],
  [27.2981834, -7.01095724],
  [27.7852192, -7.27304506],
  [27.5622101, -6.52031708],
])

@pca006132 pca006132 requested a review from elalish May 12, 2023 11:44
@pca006132
Copy link
Collaborator Author

Btw is there a way I can avoid GitHub from auto-closing the linked issue?

@codecov
Copy link
codecov bot commented May 12, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (1615b72) 89.73% compared to head (8f8fba6) 89.74%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #430   +/-   ##
=======================================
  Coverage   89.73%   89.74%           
=======================================
  Files          35       35           
  Lines        4200     4201    +1     
=======================================
+ Hits         3769     3770    +1     
  Misses        431      431
Impacted Files Coverage Δ
src/manifold/src/csg_tree.cpp 91.82% <100.00%> (+0.03%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@elalish
Copy link
Owner
elalish commented May 12, 2023

Btw is there a way I can avoid GitHub from auto-closing the linked issue?

Yes, just avoid the word "Fixes". Maybe something like "partially addresses". Also, that bug is pretty convoluted - nothing wrong with closing it and starting a more specific one.

elalish
elalish approved these changes 8000 May 12, 2023
View reviewed changes
Copy link
Owner
@elalish elalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find, thanks!

@pca006132 pca006132 closed this May 12, 2023
@pca006132 pca006132 reopened this May 12, 2023
@pca006132 pca006132 mentioned this pull request May 12, 2023
Closed
@pca006132 pca006132 merged commit 18abd3f into elalish:master May 12, 2023
@pca006132 pca006132 deleted the fix-compose branch August 15, 2023 12:53
@elalish elalish mentioned this pull request Nov 3, 2023
Merged
cartesian-theatrics pushed a commit to cartesian-theatrics/manifold that referenced this pull request Mar 11, 2024
@pca006132
fix compose index error (elalish#430)
2b30a1a 
* fix compose index error

elalish#425 (comment)

* simplify test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elalish elalish elalish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Manifold metadata
2 participants
@pca006132 @elalish
0