8000 add unionError test case by Loosetooth · Pull Request #429 · elalish/manifold · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add unionError test case #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account relate 8000 d emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2023
Merged

add unionError test case #429

merged 1 commit into from
May 11, 2023

Conversation

Loosetooth
Copy link
Contributor

See the discussion for more details.

The test case is currently a bit convoluted. I'm open to simplifying it, but have not managed to find a simpler error case in manifoldcad.org, or C++.

@google-cla
Copy link
google-cla bot commented May 10, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov
Copy link
codecov bot commented May 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (58fb7e3) 89.73% compared to head (3946066) 89.73%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #429   +/-   ##
=======================================
  Coverage   89.73%   89.73%           
=======================================
  Files          35       35           
  Lines        4200     4200           
=======================================
  Hits         3769     3769           
  Misses        431      431

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@elalish
Copy link
Owner
elalish commented May 10, 2023

Would you mind signing our CLA? It's pretty innocuous, but sadly required.

@Loosetooth
Copy link
Contributor Author

It's signed.

Some ideas for simplifying the test case:

  1. try removing path points and see if it still breaks.
  2. move the path vector to another file, and import it in the test file. (Not sure how easy that is in C++)

If you have any other ideas let me know.

elalish
elalish approved these changes May 11, 2023
View reviewed changes
Copy link
Owner
@elalish elalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll tweak it from here while I debug.

@elalish elalish merged commit 1615b72 into elalish:master May 11, 2023
@pca006132 pca006132 mentioned this pull request May 12, 2023
Merged
@elalish elalish mentioned this pull request Jun 8, 2023
Merged
cartesian-theatrics pushed a commit to cartesian-theatrics/manifold that referenced this pull request Mar 11, 2024
@Loosetooth
add unionError test case (elalish#429)
db25439
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elalish elalish elalish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Loosetooth @elalish
0