fix: don't replace ics23 when using sdk v0.46.7 #1201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedekunze
approved these changes
Dec 30, 2022
|
@Mergifyio backport release/v10.0.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 30, 2022
* don't explicitly patch dragonberry, the software will default to ics23 v0.9.0 * make proto-gen * use ethermint v0.20.0 Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> (cherry picked from commit 291ed0d) # Conflicts: # x/claims/types/tx.pb.go # x/inflation/types/tx.pb.go # x/recovery/types/tx.pb.go # x/revenue/types/events.pb.go
fedekunze
pushed a commit
that referenced
this pull request
Jan 3, 2023
* fix(deps): don't replace ics23 when using SDK v0.46.7 (#1201) * don't explicitly patch dragonberry, the software will default to ics23 v0.9.0 * make proto-gen * use ethermint v0.20.0 Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> (cherry picked from commit 291ed0d) # Conflicts: # x/claims/types/tx.pb.go # x/inflation/types/tx.pb.go # x/recovery/types/tx.pb.go # x/revenue/types/events.pb.go * update changelog * fix changelog * delete all *.pb.go and *.pb.gw.go and execute make proto-all to rebuild * run go mod tidy Co-authored-by: Jacob Gadikian <jacobgadikian@gmail.com> Co-authored-by: Freddy Caceres <facs95@gmail.com> Co-authored-by: MalteHerrmann <malte@evmos.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SDK v0.46.7 introduced a new ics23 libary, v0.9.0, which shouldn't be replaced with v0.8.0.
This PR addresses the issue, and then runs
make proto-genAll items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
PR review checkboxes:
I have...
Unreleasedsection inCHANGELOG.mdCode maintenance:
I have...
godocand code comments.docs/) or specification (x/<module>/spec/)Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.
I have...