8000 Bump ics23 v0.9.0 by giansalex · Pull Request #1198 · evmos/evmos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bump ics23 v0.9.0 #1198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Bump ics23 v0.9.0 #1198

wants to merge 1 commit into from

Conversation

giansalex
Copy link
Contributor
@giansalex giansalex commented Dec 28, 2022 •
edited
Loading

Description

According to cosmos-sdk v0.46.7 release notes, ics23 v0.9.0 should be used instead v0.8.0

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

PR review checkboxes:

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • included the correct type prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • provided a link in the PR description to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all required CI checks have passed

Code maintenance:

I have...

  • written unit and integration tests
  • added relevant godoc and code comments.
  • updated relevant documentation (docs/) or specification (x/<module>/spec/)

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code

@giansalex giansalex requested a review from a team as a code owner December 28, 2022 21:00
@giansalex giansalex requested review from facs95 and GAtom22 and removed request for a team December 28, 2022 21:00
@VictorTrustyDev
Copy link
Contributor

Ethermint as well https://github.com/evmos/ethermint/blob/ff3085ffe64b51f8608e52523bc32d54fda7371d/go.mod#L196-L197

@faddat
Copy link
Contributor
faddat commented Dec 30, 2022 •
edited
Loading

First notes

Hey, didn't see this PR before making mine. Yours came first, so,

closes: #1200

I'll close my PR, #1201

<3

Second notes

Seems that these changes also require a make proto-gen.

I've re-opened #1201

@giansalex giansalex closed this Dec 30, 2022
@giansalex giansalex deleted the ics-v9 branch December 30, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facs95 facs95 Awaiting requested review from facs95 facs95 is a code owner automatically assigned from evmos/core-engineering

@GAtom22 GAtom22 Awaiting requested review from GAtom22 GAtom22 is a code owner automatically assigned from evmos/core-engineering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giansalex @VictorTrustyDev @faddat
0