8000 ENG 256 Fix gosec vulnerabilities by danburck · Pull Request #114 · evmos/evmos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ENG 256 Fix gosec vulnerabilities #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 25, 2021
Merged

ENG 256 Fix gosec vulnerabilities #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a011c5
Improvement(Evmos): Fix gosec vulnerabilities
danburck Nov 24, 2021
7322e14
Merge branch 'main' into ENG-256-fix-gosec-issues
danburck Nov 24, 2021
dd24879
fix merge conflict in network.go
danburck Nov 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/export.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,9 @@ func (app *Evmos) prepForZeroHeightGenesis(ctx sdk.Context, jailAllowedAddrs []s
counter++
}

iter.Close()
if err := iter.Close(); err != nil {
return err
}

if _, err := app.StakingKeeper.ApplyAndReturnValidatorSetUpdates(ctx); err != nil {
return err
Expand Down
5 changes: 4 additions & 1 deletion cmd/evmosd/testnet.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,7 +556,10 @@ func startTestnet(cmd *cobra.Command, args startArgs) error {
}

cmd.Println("press the Enter Key to terminate")
fmt.Scanln() // wait for Enter Key
_, err = fmt.Scanln() // wait for Enter Key
if err != nil {
return err
}
testnet.Cleanup()

return nil
Expand Down
4 changes: 2 additions & 2 deletions x/intrarelayer/types/events.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ const (
EventTypeBurn = "burn"
EventTypeRegisterCoin = "register_coin"
EventTypeRegisterERC20 = "register_erc20"
EventTypeToggleTokenRelay = "toggle_token_relay" // nolint: gosec
EventTypeToggleTokenRelay = "toggle_token_relay" // #nosec
EventTypeUpdateTokenPairERC20 = "update_token_pair_erc20"

AttributeKeyCosmosCoin = "cosmos_coin"
AttributeKeyERC20Token = "erc20_token" // nolint: gosec
AttributeKeyERC20Token = "erc20_token" // #nosec
AttributeKeyReceiver = "receiver"

ERC20EventTransfer = "Transfer"
Expand Down
2 changes: 1 addition & 1 deletion x/intrarelayer/types/proposal.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import (
const (
ProposalTypeRegisterCoin string = "RegisterCoin"
ProposalTypeRegisterERC20 string = "RegisterERC20"
ProposalTypeToggleTokenRelay string = "ToggleTokenRelay" // nolint: gosec
ProposalTypeToggleTokenRelay string = "ToggleTokenRelay" // #nosec
ProposalTypeUpdateTokenPairERC20 string = "UpdateTokenPairERC20"
)

Expand Down
0