ENG 256 Fix gosec vulnerabilities #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENG-256 Fix gosec issues on Ethermint and Evmos
Follow up from ENG-255
cc: @prajjwol |
Codecov Report
@@ Coverage Diff @@
## main #114 +/- ##
==========================================
- Coverage 72.73% 72.68% -0.05%
==========================================
Files 23 23
Lines 1665 1666 +1
==========================================
Hits 1211 1211
- Misses 400 401 +1
Partials 54 54
|
fedekunze
approved these changes
Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://linear.app/tharsis/issue/ENG-256/fix-gosec-issues-on-ethermint-and-evmos
Description
This PR fixes the last vulerabilities pointed out by
gosecin order to makegosecrequired for github workflows.Note
On merge, an admin of this repo needs to set the gosec github action to required