8000 28 include record key by rknizzle · Pull Request #34 · dominikbraun/timetrace · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

28 include record key #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

28 include record key #34

wants to merge 2 commits into from

Conversation

rknizzle
Copy link
Contributor

timetrace list records output now contains the column 'Key'

Example:
Screen Shot 2021-05-17 at 9 58 39 PM

Resolves #28

rknizzle added 2 commits May 17, 2021 21:50
Refactor: Rename dateLayout -> timeLayout
d9601fb 
	- Because this value just defines how to display the hours and
	minutes and the name 'dateLayout' could be confused with the
	layout of the record key YYYY-MM-DD-HH-MM which im going to add
Output the record key (YYYY-MM-DD-HH-MM) when listing records
5c69998 
	- Add a keyLayout field so the layout is appropriate based on 12
	or 24 hour clock
@rknizzle rknizzle force-pushed the 28-include-record-key branch from 0b96e44 to 5c69998 Compare May 18, 2021 02:04
@dominikbraun dominikbraun self-requested a review May 18, 2021 06:26
@dominikbraun dominikbraun mentioned this pull request May 19, 2021
Merged
@aaronsheah
Copy link
Contributor
aaronsheah commented May 19, 2021 •
edited
Loading

Hi @rknizzle as part of adding a new component Formatter im looking to refactor how we parse/format the strings. what do of this proposed changes in #44 to achieve your change

@rknizzle
Copy link
Contributor Author

Hi @rknizzle as part of adding a new component Formatter im looking to refactor how we parse/format the strings. what do of this proposed changes in #44 to achieve your change

@aaronsheah I like the addition of the Formatter type. Looks good!

@rknizzle rknizzle closed this May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikbraun dominikbraun Awaiting requested review from dominikbraun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

timetrace list records should include "record key"
2 participants
@rknizzle @aaronsheah
0