10000 #28 Proposed changes of adding Record Key in `list` using `Formatter` by aaronsheah · Pull Request #44 · dominikbraun/timetrace · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

#28 Proposed changes of adding Record Key in list using Formatter #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 22, 2021
Merged

#28 Proposed changes of adding Record Key in list using Formatter #44

merged 3 commits into from
May 22, 2021

Conversation

aaronsheah
Copy link
Contributor
@aaronsheah aaronsheah commented May 19, 2021 •
edited
Loading

12 Hour

Screenshot 2021-05-19 at 23 40 32

24 Hour

Screenshot 2021-05-19 at 23 42 11

resolves #28

@aaronsheah aaronsheah mentioned this pull request May 19, 2021
Closed
@aaronsheah aaronsheah changed the title #28 Proposed changes using Formatter #28 Proposed changes of adding Record Key in list using Formatter May 19, 2021
@dominikbraun dominikbraun self-requested a review May 19, 2021 20:04
dominikbraun
dominikbraun requested changes May 19, 2021
View reviewed changes
Copy link
Owner
@dominikbraun dominikbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aligator PTAL

@aaronsheah
Copy link
Contributor Author

Thanks @dominikbraun silly mistakes, must have still haven't woken up then 😆

@aaronsheah aaronsheah requested a review from dominikbraun May 19, 2021 22:43
@dominikbraun
Copy link
Owner

@aaronsheah I think you need to use the new Formatter for get and delete as well - then this PR can be merged 😄

@aligator
Copy link
Collaborator

@aligator PTAL

Looks good to me :-)

@aaronsheah
Copy link
Contributor Author

@dominikbraun updated :)

dominikbraun
dominikbraun approved these changes May 22, 2021
View reviewed changes
Copy link
Owner
@dominikbraun dominikbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dominikbraun dominikbraun merged commit f251189 into dominikbraun:main May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikbraun dominikbraun dominikbraun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

timetrace list records should include "record key"
3 participants
@aaronsheah @dominikbraun @aligator
0