8000 Improved chunk tracking during clone by timsehn · Pull Request #9299 · dolthub/dolt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improved chunk tracking during clone #9299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 3, 2025
Merged

Improved chunk tracking during clone #9299

merged 10 commits into from
Jun 3, 2025
+20 −5

Conversation

timsehn
Copy link
Contributor
@timsehn timsehn commented Jun 2, 2025 •
edited
Loading

Decrement the chunk counter when a file completes. Add a completion status message. Fix a potential race that @reltuk identified in review.

@timsehn
Added a defensive check to make sure remaining chunks is never less t…
103f3b1 
…han downloading chunks. Added a file map to ensure chunks are only counted once.
@timsehn
Copy link
Contributor Author
timsehn commented Jun 2, 2025

Fixes #9240

@timsehn timsehn linked an issue Jun 2, 2025 that may be closed by this pull request
Clone Status reports more chunks being downloaded than it says exist #9240
Closed
@timsehn timsehn requested a review from reltuk June 2, 2025 23:34
@coffeegoddd
Copy link
Contributor

@timsehn DOLT

comparing_percentages
100.000000 to 100.000000
version result total
f71522e ok 5937457
version total_tests
f71522e 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
d8babb2 ok 5937457
version total_tests
d8babb2 5937457
correctness_percentage
100.0

reltuk
reltuk approved these changes Jun 3, 2025
View reviewed changes
Copy link
Contributor
@reltuk reltuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@timsehn timsehn merged commit 7a7030b into main Jun 3, 2025
21 of 22 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Jun 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reltuk reltuk reltuk approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clone Status reports more chunks being downloaded than it says exist
3 participants
@timsehn @coffeegoddd @reltuk
0