dolt 1.54.2 #225681
Merged
dolt 1.54.2 #225681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenrui333
approved these changes
Jun 4, 2025
|
🤖 An automated task has requested bottles to be published to this PR. Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bumpCreated with
brew bump-formula-pr.release notes
The clone code works by listing the remote table files and downloading them into the local table file store. When the remote is a remoteapi implementation, like a DoltHub repository, this resulting in listing the remote table files and using URLs to fetch each of them.
The URLs returned from these APIs can expire and they need to be refreshed. This refresh can happen in two ways:
The Clone code has explicit support for doing (2), and it is necessary for remoteapi implementations with expiring URLs but without explicit RefreshTableFileUrl support. dolt itself, when running a remote as part of sql-server for example, does not implement RefreshTableFileUrl support, and so the re-list support is still necessary.
This PR changes the Clone implementation so that, on a retry, it makes all the newly returned table file sources available for the next try, but it keeps the old sources around if they no longer come back from ListTableFiles. In this way, we get strictly more robust behavior than before.
The downside is that, when the remote file is actually gone, the Clone code will continue attempting to download it until it reaches a terminal download failure. This change in behavior is not as disruptive as the current behavior, and so we make this new trade off for now.
Decrement the chunk counter when a file completes. Add a completion status message. Fix a potential race that @reltuk identified in review.
fixes dolthub/dolt#9294
Even if there is an empty diff
dolt_branch_status()This PR implements
dolt_branch_status(<base_branch>, <feature_branch1>, <feature_branch2>, ...).The function compares
base_branchagainst each of the feature branches and outputs a table that lists how many commits ahead and behind base branch.Additionally, this PR contains some cleanup/refactoring.
addresses: Add sql function to determine "who is ahead" dolthub/dolt#9090
go-mysql-server
This is a proposed fix for Dolt issue: Dolt start time of queries in logs is all pinned to the connection open start time dolthub/dolt#8909
I'm not certain if we want to just add this field or replace connect time. I think this implementation is safer.
The ORDER BY clauses in aggregates like
group_concatdo not work correctly with subqueries. Lots of varied tests demonstrating this defect.IS NULLexpressions with recordsThe implementation in GMS for
IS NULLchecks if the value isNULLor not. For record and composite types in Postgres,IS NULLneeds to check if each value in the record or composite type isNULLto determine if the value isNULL. See Add support forIS NULLexpression on records dolthub/doltgresql#1520 for more details.This change creates a new shared type, named
TupleValue, in GMS that is used for record values (and eventually, composite type values). I also considered giving Doltgres it's own, customIsNullimplementation, but the analyzer does specific checks and optimizations when it looks for*expression.IsNullinstances, which would stop working correctly.Depends on 416
vitess
REVOKE ALL...This PR fixes
REVOKE ALL [PRIVILEGES], GRANT OPTION ...so that it parse to the same thing asREVOKE ALL PRIVILEGESas they are equivalent in MySQL. TheGRANTprivilege is already part of all privileges, specifying it is just for clarity.Additionally, this PR adds syntax support for the
IF EXISTSoption andIGNORE UNKNOWN USERoption that is part ofREVOKEstatements.MySQL Docs: https://dev.mysql.com/doc/refman/8.4/en/revoke.html
Syntax for:
REVOKE ALL PRIVILEGES, GRANT OPTION FROM ...errors with "not yet implemented" dolthub/dolt#9228Closed Issues
dolt_helpset of system tablesView the full release notes at https://github.com/dolthub/dolt/releases/tag/v1.54.2.