Require Doctrine Deprecations 1.1.5 #6962
8000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
approved these changes
May 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doctrine Deprecations prior to 1.1.5 use the
@beforeand@afterannotations which trigger PHPUnit deprecations on PHPUnit 11 (see #6961). In order to keep the DBAL deprecation-free, I want to reinstatefailOnPhpunitDeprecation="true"in the PHPUnit configuration (which was initially added in #6959 and then reverted in #6961). Doing so without the dependency update would fail the build with the lowest dependencies, and I don't want to introduce a separate PHPUnit configuration just for that build.We should bump the Deprecations requirement to 1.1.5. This is a non-test dependency, but it should be acceptable. Deprecations 1.0.0 was released 3 years ago, so folks had enough time to upgrade.
P.S. I think it might also work if we disabled failing on PHPUnit deprecations on the lowest build via the CLI. If the dependency update becomes a problem, we can try that, but for now I think this complication is not justified.Actually, it won't. There is a--fail-on-phpunit-deprecationCLI option but no--do-not-fail-on-phpunit-deprecationor something like that.