8000 Manually merge 4.2.x into 4.3.x by morozov · Pull Request #6961 · doctrine/dbal · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Manually merge 4.2.x into 4.3.x #6961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 17, 2025
Merged

Manually merge 4.2.x into 4.3.x #6961

merged 7 commits into from
May 17, 2025

Conversation

morozov
Copy link
Member
@morozov morozov commented May 17, 2025 •
edited
Loading

I've reverted the failOnPhpunitDeprecation="true" configuration introduced in #6959. The problem is that even though the test suite itself is deprecation-free, the dependencies aren't. The following is triggered by Doctrine Deprecations (failing build):

There were 58 PHPUnit test runner deprecations:

1) Metadata found in doc-comment for method Doctrine\DBAL\Tests\DriverManagerTest::enableDeprecationTracking(). Metadata in doc-comments is deprecated and will no longer be supported in PHPUnit 12. Update your test code to use attributes instead.

...

58) Metadata found in doc-comment for method Doctrine\DBAL\Tests\Platforms\SQLite\ComparatorTest::verifyDeprecationsAreTriggered(). Metadata in doc-comments is deprecated and will no longer be supported in PHPUnit 12. Update your test code to use attributes instead.

For some reason, I cannot reproduce this locally:

$ phpunit --fail-on-phpunit-deprecation

...

OK, but there were issues!
Tests: 3501, Assertions: 5177, Skipped: 569, Incomplete: 13.

Oh, it was the lowest dependencies build. I guess, we should have just bumped the requirement.

I'm leaving the displayDetailsOnPhpunitDeprecations="true" configuration for better visibility of the deprecations.

@morozov morozov merged commit 1089fcb into doctrine:4.3.x May 17, 2025
82 checks passed
@morozov morozov mentioned this pull request May 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Merge Up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@morozov
0