Lokkke #1
Open
Lokkke #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix a few trivial typos concerning "separation" and "command"
Merge in engineering-flot
fixed typo in jquery.flot.stack.js
Use source code directly in examples
Merge flot/flot master
Add legend to tracking exemple Add series-errorbars to examples list
Fix examples
Selection will not work unless the `jquery.event.drag.js` library is included.
Update the selection example.
Cancel jQuery animation queue on hover off
Fix - ReferenceError when using fillbetween (#1727)
Add a configuration option to determine if the selection decorations …
…eplace-this-with-window Fix - flot.resize e.setTimeout is not a function #1715
Pan and zoom limits
Fix undefined variable error
Allow user defined tickFormatter for time axis
* Fixed eslint configuration and fixed errors * Reverted unintended changes * Fixed new lint errors * Fixed even more lint errors
* Removed webcharts-development-settings dependency * Fixed package-lock
* Don't show endpoints for horizontal bar charts * Add test
When tickDecimals is null adding an extra tickdecimal when range is .25 will fail. 0 - 0.25 - 0.5 - 0.75 - 1 will be incorrectly rounded to 0 - 0.3 - 0.5 - 0.8
* Attempt to remove problem dependency. * Disable some low-priority misbehaving tests.
…crosecond min tick size (#1802) This PR addresses two already-reported issues when using micro epoch with the time axis # 1. Missing ticks when using time axis The code that resets the time of the first tick does not takes into account the seconds/millis/micro steps:  This PR adds the following sections to reset the micro and millis when needed: ```javascript if (step >= timeUnitSize.millisecond) { d.setMicroseconds(0); } if (step >= timeUnitSize.second) { d.setMilliseconds(0); } ``` The result after the fix:  This also fixes another issue mentioned here: #1743 # 2. Infinite loop in dateTickGenerator Mentioned here: #1792 In some cases, the date tick generator will run in an infinite loop due to a bug in the custom micro date implementation provided by Flot time plugin. In short: The micro epoch is rounded to 3 decimals AFTER setting the date using the default Date.setTime prototype, which means that when the micro epoch is of form 1645527365.999999999, setTime will receive 1645527365 instead of 1645527366. This caused an infinite loop within dateTickGenerator. This PR fixes this issue by first rounding the micro epoch then calling the Date.setTime original prototype.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.